feat(build): handle installation and linking of dependencies for pinocchio collision support #161
Conversation
|
The tests fail since the base docker image used to run the tests on doesn't have any of our new dependencies installed..i'd say we run the tests ourselves until we figure out the new CI (#159) |
| RUN --mount=type=cache,target=${HOME}/.cache,id=pip-${TARGETPLATFORM}-${CACHEID},uid=1000 \ | ||
| python3 -m pip install --prefix=/tmp/python /python | ||
| RUN mv /tmp/python/local /tmp/python-usr | ||
|
|
||
| FROM cpp-test as python-test |
There was a problem hiding this comment.
Seems like this could be part of test? Is there a specific time we might want to run just part of the tests?
There was a problem hiding this comment.
Most of time in development, we develop in cpp first and then we write the python bindings. So we want to write and test cpp first before we continue with python.
There was a problem hiding this comment.
OK, just seems like it could stay the same stage with all the tests. As long as you keep the C++ tests running first it would be a similar experience. Anyway, not a blocker.
d581742 to
bb9dce0
Compare
All tested and looks good now! |
Description
This PR solves the issue by installing all required dependencies and add compile definitions for the collision support with pinocchio.
Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: