Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to using evaluator as script. #94

Merged
merged 13 commits into from
Aug 21, 2024
Merged

switch to using evaluator as script. #94

merged 13 commits into from
Aug 21, 2024

Conversation

FlorianPommerening
Copy link
Member

No description provided.

@FlorianPommerening FlorianPommerening mentioned this pull request Aug 16, 2024
Closed
@FlorianPommerening
Copy link
Member Author

From my side, this is ready to merge now.

@FlorianPommerening FlorianPommerening mentioned this pull request Aug 19, 2024
Closed
ClemensBuechner
ClemensBuechner approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ClemensBuechner ClemensBuechner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the design in general and am okay with merging it. There are some minor things where I see opportunities for clarifications, and they are mostly small things to do I believe. But they should definitely not block us from merging this soon.

@ClemensBuechner ClemensBuechner merged commit a1bb253 into main Aug 21, 2024
@ClemensBuechner ClemensBuechner deleted the issue82 branch August 21, 2024 15:27
@ClemensBuechner ClemensBuechner linked an issue Aug 21, 2024 that may be closed by this pull request
make evaluator script executable with command line arguments PDDL/SAS files for testing #82
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClemensBuechner ClemensBuechner ClemensBuechner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make evaluator script executable with command line arguments PDDL/SAS files for testing
2 participants
@FlorianPommerening @ClemensBuechner