Adding Yep Chat in Taktak #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a toolbar button that allows users to toggle the visibility of the chat side panel. The button provides a visual cue by highlighting with a rounded background when the chat panel is active.
…nel can be toggled from the toolbar and displays AI chat alongside current web content.
…so it can be localized into different languages.
…m to WebUI layer in progress)
… suitable for conversations
…g & error handling)
… pipe issue needs to be fixed though)
…sults in the debug console
Deleted ChatContextObserver class and its dependencies to simplify codebase. Adjusted related headers and implementation files to reflect the removal, and corrected remaining references and comments accordingly.
Implemented different prompts for chat actions: summarize page, explain page, and fact check page. Updated function signatures and button click handlers to utilize the new action-specific prompts.
Previously, the full content was passed to the query without length restriction, which could cause issues. Now, the content is truncated to a maximum of 32768 tokens to ensure it adheres to the defined limit.
…n loading slow websites.
Introduced methods to save and retrieve SiteInfo from the cache to improve efficiency and maintain state consistency across page interactions. Updated chat panel behavior to handle cached SiteInfo appropriately, ensuring seamless user experience and accurate context handling in conversations. Enhanced logic to prevent redundant SiteInfo and related states updates for the same URL.
…ng the same site.
…ache when the user opens or closes the chat panel.
…ing pointer error
Change-Id: I085a541bc7d5e39ffa33010ef17f64f00e28c6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6313317 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7046@{#1} Cr-Branched-From: eebb4a4-refs/heads/main@{#1426832}
Change-Id: Icf8096f1ddd449f29ea5002104303f4fb285bf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6315039 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7046@{#2} Cr-Branched-From: eebb4a4-refs/heads/main@{#1426832}
…in reasoning text are ignored to parse
nyinyithann
pushed a commit
that referenced
this pull request
Mar 26, 2025
Change-Id: I07723276d07e4ad05095f004f3f4b9776f1d4fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6321305 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7049@{#1} Cr-Branched-From: 2dab784-refs/heads/main@{#1427262}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on integrating Yep Chat into Taktak.
Please note that this PR is currently intended for reference purposes only. The branch
tt/feature/yepchathas already been merged intott135/develop, which is now being utilized as the development base.