Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: enable remote execution on CI for Linux #296

Merged
merged 10 commits into from
May 11, 2024
Merged

chore!: enable remote execution on CI for Linux #296

merged 10 commits into from
May 11, 2024

Conversation

aherrmann
Copy link
Owner

@aherrmann aherrmann commented May 10, 2024

  • Enables remote execution on CI.

  • Installs the BuildBuddy platform and toolchain as a dev-dependency required for C/C++ targets, primarily protoc.

  • Enable remote execution

  • Configure hermetic_cc_toolchain

  • Configure more concurrent jobs for RE

  • Revert "Configure hermetic_cc_toolchain"

  • Install and configure BuildBuddy toolchains

  • Remove -j from nm invocations

  • Tag buildifier_test as no-remote-exec

  • Make remote configuration explicit

  • Enable remote execution on CI

aherrmann added 4 commits May 11, 2024 09:52
This provides a hermetic cc toolchain to build protoc, which is required
by Gazelle and docs generation. Without a hermetic cc toolchain these
build actions would fail with remote execution enabled.
This reverts commit d3b6536.

The hermetic_cc_toolchain does not include `nm` which we need for some
test cases.
aherrmann added 5 commits May 11, 2024 09:58
Configure the BuildBuddy provided platform and toolchains for remote
execution.
The -j flag is not supported by the `nm` on the remote execution nodes.
The test runs buildifier on the local repository outside of the sandbox.
This cannot work remotely.
@aherrmann aherrmann force-pushed the remote-exec branch 2 times, most recently from ad9cce3 to b41ba5b Compare May 11, 2024 08:09
@aherrmann aherrmann changed the title chore!: enable remote execution on CI chore!: enable remote execution on CI for Linux May 11, 2024
@aherrmann aherrmann enabled auto-merge May 11, 2024 08:12
@aherrmann aherrmann merged commit 60b1aa5 into main May 11, 2024
44 of 54 checks passed
@aherrmann aherrmann deleted the remote-exec branch May 11, 2024 08:21
@aherrmann aherrmann mentioned this pull request Jul 8, 2024
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant