chore: update Zig versions to 0.11.0 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
github-actions
bot
commented
Nov 22, 2023
•
- Check that the automatic version replacements make sense.
aherrmann
approved these changes
Nov 22, 2023
The package CLI interface changed in the Zig compiler in a way that requires some reworking in rules_zig to support. At this stage it is likely far too costly for too little benefit to try and support both interfaces at the same time.
The new `--mod` and `--deps` flags solve this problem.
The API changed
The output base is now included in debug outputs on Linux as well. And additionally, in release safe and release small outputs. Debug outputs do not have to be reproducible according to Zig's specification. But, release builds should be.
7c29504 to
dbf50d1
Compare
|
This causes a regression on reproducibility. Absolute paths are included in build outputs, see #79 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.