[#426] Fix a problem in pgagroal_bind
#437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the configuration `host` is set to `*`, meaning all the interfaces, the `pgagroal_bind` function was always returning a true value even if no available bind addresses were left. In order to fix this, the commit tests if the `star_length` variable has been set to something non-zero, otherwise no more sockets are available (bound) and the function returns a `1` to indicate an error. Close agroal#426
|
Rebased and merged. Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the configuration
hostis set to*, meaning all the interfaces, thepgagroal_bindfunction was always returning a true value even if no available bind addresses were left.In order to fix this, the commit tests if the
star_lengthvariable has been set to something non-zero, otherwise no more sockets are available (bound) and the function returns a1to indicate an error.Close #426