pgagroal-cli reload added server wrong warn about restart
#235
Labels
feature
New feature
Comments
jesperpedersen
pushed a commit
that referenced
this issue
May 12, 2022
The `restart_server()` function checks if two configurations identify the same server. When a new server is added, there is no previous configuration to compare against, and therefore there is no need to emit a restart warning message between the added server and "nothing". Close #235
fluca1978
added a commit
to fluca1978/pgagroal
that referenced
this issue
May 19, 2022
In order to make calls to `pgagroal_prefill()` consistent around the code and avoid repetitions, there is a new function named `pgagroal_prefill_if_can()` that wraps several checks and does the forking and prefilling. Therefore there is no need to check against the configuration limits and users before calling `pgagroal_prefill()` because `pgagroal_prefill_if_can()` will do by itself. Also `pgagroal_prefill_if_can()` will check for a primary server, and in the case there is none, will avoid issuing the prefill at all. Last, this introduces also the `pgagroal_can_prefill()` function that is used in turn by `pgagroal_prefill_if_can()` and aims at testing the configuration for the presence of limits and users. This function can be used as a condition checker before doing clean-up stuff right before calling `pgagroal_prefill_if_can()`. Close agroal#223
jesperpedersen
pushed a commit
that referenced
this issue
May 23, 2022
In order to make calls to `pgagroal_prefill()` consistent around the code and avoid repetitions, there is a new function named `pgagroal_prefill_if_can()` that wraps several checks and does the forking and prefilling. Therefore there is no need to check against the configuration limits and users before calling `pgagroal_prefill()` because `pgagroal_prefill_if_can()` will do by itself. Also `pgagroal_prefill_if_can()` will check for a primary server, and in the case there is none, will avoid issuing the prefill at all. Last, this introduces also the `pgagroal_can_prefill()` function that is used in turn by `pgagroal_prefill_if_can()` and aims at testing the configuration for the presence of limits and users. This function can be used as a condition checker before doing clean-up stuff right before calling `pgagroal_prefill_if_can()`. Close #223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #233, when a new server is added to the configuration and the
pgagroal-cli reloadis issued, the system warns the user about a restart:this is because the
restart_server()function gets a new server that cannot be compared to a previous one, since it is added, and thus emits the warning. This is not a real bug, but a misleading message.The text was updated successfully, but these errors were encountered: