Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 400 Bad Request for any method except 'GET' #217

Closed
nikitabugrovsky opened this issue Apr 3, 2022 · 0 comments
Closed

Return 400 Bad Request for any method except 'GET' #217

nikitabugrovsky opened this issue Apr 3, 2022 · 0 comments
Assignees
@nikitabugrovsky
Labels
enhancement Improvement to an existing feature

Comments

@nikitabugrovsky
Copy link
Contributor

Is your feature request related to a problem? Please describe.

At the moment if we send request to pgagroal /metrics endpoint using any method except 'GET', we receive 403 Forbidden. 403 indicates that the server understands the request but refuses to authorize. That is not exactly the case with the pgagroal exporter.

Describe the solution you'd like

Introduce new check in the code that will allow to return 400 Bad Request for any method except 'GET'.

Ref: Hypertext Transfer Protocol -- HTTP/1.1
@nikitabugrovsky nikitabugrovsky added the feature New feature label Apr 3, 2022
nikitabugrovsky added a commit to nikitabugrovsky/pgagroal that referenced this issue Apr 3, 2022
@nikitabugrovsky
[agroal#217] Return 400 Bad Request for any method except 'GET'
08f1ca2
@jesperpedersen jesperpedersen added enhancement Improvement to an existing feature and removed feature New feature labels Apr 4, 2022
jesperpedersen pushed a commit that referenced this issue Apr 4, 2022
@nikitabugrovsky @jesperpedersen
[#217] Return 400 Bad Request for any method except 'GET'
ad02daa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikitabugrovsky nikitabugrovsky

Labels
enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jesperpedersen @nikitabugrovsky