Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better messages when entering master password #206

Closed
fluca1978 opened this issue Feb 21, 2022 · 0 comments
Closed

Better messages when entering master password #206

fluca1978 opened this issue Feb 21, 2022 · 0 comments
Assignees
@fluca1978
Labels
enhancement Improvement to an existing feature

Comments

@fluca1978
Copy link
Collaborator

In 1.4 when the user enters a master password thru pgagroal-admin, in the case the password is incorrect (i.e., wrong size) the program keeps asking the user for a password without producing any error message that can help the user to understand what she is doing wrong.

Related to #200
@fluca1978 fluca1978 added the feature New feature label Feb 21, 2022
@fluca1978 fluca1978 mentioned this issue Feb 21, 2022
Closed
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Feb 21, 2022
@fluca1978
[agroal#206] Remove is_valid_password function and provide better mes…
0a89423 
…sages.

Close agroal#206.

See <agroal#200 (comment)>.
The is_valid_password() was checking only the password length and the fact
that was made by ASCII chars.
The check for the length can be done "inline" directly within a loop.
Added a constant with the minimal length of the password, so that it is possible
to insert a warning message for the user in the case she inputs a too short password.

The system also prompts the user for a password with a message that explicitly tells
her the password will not appear on the terminal.

See also the initial work on agroal#200.
@fluca1978 fluca1978 mentioned this issue Feb 21, 2022
Closed
@jesperpedersen jesperpedersen added enhancement Improvement to an existing feature and removed feature New feature labels Feb 21, 2022
jesperpedersen pushed a commit that referenced this issue Feb 21, 2022
@fluca1978 @jesperpedersen
[#206] Remove is_valid_password function and provide better messages.
279268f 
Close #206.

See <#200 (comment)>.
The is_valid_password() was checking only the password length and the fact
that was made by ASCII chars.
The check for the length can be done "inline" directly within a loop.
Added a constant with the minimal length of the password, so that it is possible
to insert a warning message for the user in the case she inputs a too short password.

The system also prompts the user for a password with a message that explicitly tells
her the password will not appear on the terminal.

See also the initial work on #200.
@fluca1978 fluca1978 mentioned this issue Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fluca1978 fluca1978

Labels
enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#206] Remove is_valid_password function and provide better messages. fluca1978/pgagroal
2 participants
@jesperpedersen @fluca1978