feat: Add GetParamSetIfExists to prevent panic on breaking param ch…

…anges (cosmos#12724)
agoric-labs · Sep 28, 2024 · ebabdd9 · ebabdd9
1 parent 5c1f637
commit ebabdd9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -44,6 +44,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ### Improvements
 
+* (x/params) [#12724](https://github.com/cosmos/cosmos-sdk/pull/12724) Add `GetParamSetIfExists` function to params `Subspace` to prevent panics on breaking changes.
 * [#12668](https://github.com/cosmos/cosmos-sdk/pull/12668) Add `authz_msg_index` event attribute to message events emitted when executing via `MsgExec` through `x/authz`.
 * [#12697](https://github.com/cosmos/cosmos-sdk/pull/12697) Upgrade IAVL to v0.19.0 with fast index and error propagation. NOTE: first start will take a while to propagate into new model.
 

diff --git a/x/params/types/common_test.go b/x/params/types/common_test.go
@@ -93,6 +93,15 @@ func (p *paramsV2) ParamSetPairs() types.ParamSetPairs {
 	}
 }
 
+func (p *paramsV2) ParamSetPairs() types.ParamSetPairs {
+	return types.ParamSetPairs{
+		{keyUnbondingTime, &p.UnbondingTime, validateUnbondingTime},
+		{keyMaxValidators, &p.MaxValidators, validateMaxValidators},
+		{keyBondDenom, &p.BondDenom, validateBondDenom},
+		{keyMaxRedelegationEntries, &p.MaxRedelegationEntries, validateMaxRedelegationEntries},
+	}
+}
+
 func paramKeyTable() types.KeyTable {
 	return types.NewKeyTable().RegisterParamSet(&params{})
 }