runservice: fix/improve executor delete logic #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't fail tasks inside the delete executor action, just delete the executor from etcd * The scheduler, when detecting a task without a related executor will mark the task as failed and correctly set end time of the task and its steps.
feed040 to
b81ad4c
Compare
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
…lete runservice: fix/improve executor delete logic
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
…lete runservice: fix/improve executor delete logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't fail tasks inside the delete executor action, just delete the executor
from etcd
The scheduler, when detecting a task without a related executor will mark the
task as failed and correctly set end time of the task and its steps.