Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix wrong ProjectCommitStatusRedelivery test #522

Merged

Conversation

alessandro-sorint
Copy link
Contributor

@alessandro-sorint alessandro-sorint commented May 30, 2024

ProjectCommitStatusRedelivery tests were copied from ProjectRunWebhookRedelivery tests without updating them to use CommitStatus instead of RunWebhook APIs.

Copy link
Member

@sgotti sgotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to something cleaner:

tests: fix wrong ProjectCommitStatusRedelivery test

ProjectCommitStatusRedelivery tests were copied from ProjectRunWebhookRedelivery tests without updating them to use CommitStatus instead of RunWebhook APIs.

@sgotti sgotti changed the title fix project commit status redelivery test tests: fix wrong ProjectCommitStatusRedelivery test May 30, 2024
ProjectCommitStatusRedelivery tests were copied from ProjectRunWebhookRedelivery tests without updating them to use CommitStatus instead of RunWebhook APIs.
@alessandro-sorint alessandro-sorint force-pushed the fix-test-commitstatusredelivery branch from c79a26a to 42ac23f Compare May 30, 2024 09:19
@alessandro-sorint alessandro-sorint requested a review from sgotti May 30, 2024 11:31
@sgotti sgotti merged commit 431c8d5 into agola-io:master May 30, 2024
1 check passed
@alessandro-sorint alessandro-sorint deleted the fix-test-commitstatusredelivery branch May 30, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants