*: add detailed errors to api responses #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d42f5a to
55b0f23
Compare
Replace APIError/RemoteError Code and Message fields with an array of detailed errors UserError (APIDetailedError/RemoteDetailedError) that will contain a Code and optional error Details.
55b0f23 to
110d6a0
Compare
In addition to the standard http error codes also report a detailed error that contains an error code and an optional error detail. This is required to better explain the reason of the reported error. Since, by default if not handled in another way, an error returned by an internal service is propagated by the gateway to the client, also internal services returns detailed errors with exported error codes. This patch adds an initial round of detailed errors. They are not stable and will change in future.
110d6a0 to
d2fc020
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the standard http error codes also report a detailed
error that contains an error code and an optional error detail. This is
required to better explain the reason of the reported error.
Since, by default if not handled in another way, an error returned by
an internal service is propagated by the gateway to the client, also
internal services returns detailed errors with exported error codes.
This patch adds an initial round of detailed errors. They are not stable
and will change in future.