gitsources: split oauth2Client from gitsource #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split an oauth2Client from the gitsource. While the gitsource creates a client to the remote source an Oauth2Client doesn't requires a client to the remote sources but only handles the oauth2 flow. This also fixes an issue with gitea 1.14 (fixed in later gitea versions) where the /version endpoint requires authentication but during the oauth2 flow we don't have any auth data and so we cannot create the gitea client because during gite client creation a call to the version endpoint is done and returns an error.
dca8938 to
05588b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split an oauth2Client from the gitsource. While the gitsource creates a client to the remote source an Oauth2Client doesn't requires a client to the remote sources but only handles the oauth2 flow.
This also fixes an issue with gitea 1.14 (fixed in later gitea versions) where the /version endpoint requires authentication but during the oauth2 flow we don't have any auth data and so we cannot create the gitea client because during gite client creation a call to the version endpoint is done and returns an error.