-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add clone options #120
Conversation
@camandel Thanks for the PR. There are two different ways to implement what is asked in #3
This former is more powerful but also more confusing since the user can pass everything as "options". The latter is less error prone and won't clash with possible changes to the clone scripts generated by agola. For example, if in future we want to clone with a default user defined global/per project depth we could do this, with the former it'll be difficult since it'll depend on the arguments order/override logic if the user already provided a depth as an option. User can always use a custom clone step if they want to do special things. |
@sgotti code updated to use the second approach. At the moment only these two parameters can be converted to git arguments:
|
7459115
to
191cece
Compare
191cece
to
cd8175c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camandel LGTM. Merging. Thanks!
config: add clone options
config: add clone options
A try to fix issue #3 adding a new optional parameter ("options") in clone "step".
Example: