Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Configurable log level #1232 #1300

Merged
merged 2 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions agdb_server/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,22 @@ use crate::server_error::ServerResult;
use serde::Deserialize;
use serde::Serialize;
use std::sync::Arc;
use tracing::level_filters::LevelFilter;
use url::Url;

pub(crate) type Config = Arc<ConfigImpl>;

const CONFIG_FILE: &str = "agdb_server.yaml";

pub(crate) struct LogLevel(pub(crate) LevelFilter);

#[derive(Deserialize, Serialize)]
pub(crate) struct ConfigImpl {
pub(crate) bind: String,
pub(crate) address: Url,
pub(crate) basepath: String,
pub(crate) admin: String,
pub(crate) log_level: LogLevel,
pub(crate) data_dir: String,
pub(crate) cluster_token: String,
pub(crate) cluster: Vec<Url>,
Expand All @@ -39,6 +43,7 @@ pub(crate) fn new() -> ServerResult<Config> {
address: Url::parse("localhost:3000")?,
basepath: "".to_string(),
admin: "admin".to_string(),
log_level: LogLevel(LevelFilter::INFO),
data_dir: "agdb_server_data".to_string(),
cluster_token: "cluster".to_string(),
cluster: vec![],
Expand All @@ -49,6 +54,40 @@ pub(crate) fn new() -> ServerResult<Config> {
Ok(Config::new(config))
}

impl Serialize for LogLevel {
fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
where
S: serde::Serializer,
{
match self.0 {
LevelFilter::OFF => serializer.serialize_str("OFF"),
LevelFilter::ERROR => serializer.serialize_str("ERROR"),
LevelFilter::WARN => serializer.serialize_str("WARN"),
LevelFilter::INFO => serializer.serialize_str("INFO"),
LevelFilter::DEBUG => serializer.serialize_str("DEBUG"),
LevelFilter::TRACE => serializer.serialize_str("TRACE"),
}
}
}

impl<'de> Deserialize<'de> for LogLevel {
fn deserialize<D>(deserializer: D) -> Result<LogLevel, D::Error>
where
D: serde::Deserializer<'de>,
{
let s = String::deserialize(deserializer)?;
match s.as_str() {
"OFF" => Ok(LogLevel(LevelFilter::OFF)),
"ERROR" => Ok(LogLevel(LevelFilter::ERROR)),
"WARN" => Ok(LogLevel(LevelFilter::WARN)),
"INFO" => Ok(LogLevel(LevelFilter::INFO)),
"DEBUG" => Ok(LogLevel(LevelFilter::DEBUG)),
"TRACE" => Ok(LogLevel(LevelFilter::TRACE)),
_ => Err(serde::de::Error::custom("Invalid log level")),
}
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down Expand Up @@ -78,4 +117,37 @@ mod tests {
assert!(Path::new(CONFIG_FILE).exists());
let _config = config::new().unwrap();
}

#[test]
fn log_level() {
let level = LogLevel(LevelFilter::OFF);
let serialized = serde_yaml::to_string(&level).unwrap();
let other: LogLevel = serde_yaml::from_str(&serialized).unwrap();
assert_eq!(level.0, other.0);

let level = LogLevel(LevelFilter::ERROR);
let serialized = serde_yaml::to_string(&level).unwrap();
let other: LogLevel = serde_yaml::from_str(&serialized).unwrap();
assert_eq!(level.0, other.0);

let level = LogLevel(LevelFilter::WARN);
let serialized = serde_yaml::to_string(&level).unwrap();
let other: LogLevel = serde_yaml::from_str(&serialized).unwrap();
assert_eq!(level.0, other.0);

let level = LogLevel(LevelFilter::INFO);
let serialized = serde_yaml::to_string(&level).unwrap();
let other: LogLevel = serde_yaml::from_str(&serialized).unwrap();
assert_eq!(level.0, other.0);

let level = LogLevel(LevelFilter::DEBUG);
let serialized = serde_yaml::to_string(&level).unwrap();
let other: LogLevel = serde_yaml::from_str(&serialized).unwrap();
assert_eq!(level.0, other.0);

let level = LogLevel(LevelFilter::TRACE);
let serialized = serde_yaml::to_string(&level).unwrap();
let other: LogLevel = serde_yaml::from_str(&serialized).unwrap();
assert_eq!(level.0, other.0);
}
}
7 changes: 4 additions & 3 deletions agdb_server/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@ mod utilities;
use crate::db_pool::DbPool;
use server_error::ServerResult;
use tokio::sync::broadcast;
use tracing::Level;

#[tokio::main]
async fn main() -> ServerResult {
tracing_subscriber::fmt().with_max_level(Level::INFO).init();
let config = config::new()?;
tracing_subscriber::fmt()
.with_max_level(config.log_level.0)
.init();

let (shutdown_sender, shutdown_receiver) = broadcast::channel::<()>(1);
let config = config::new()?;
let cluster = cluster::new(&config)?;
let db_pool = DbPool::new(&config).await?;
let app = app::app(
Expand Down
Loading