AgamaProposal: handle resize of partitions #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55242ca to
f4a2eac
Compare
f4a2eac to
2e00031
Compare
2e00031 to
5dd4e2b
Compare
97388e9 to
c583677
Compare
c583677 to
ce5d46b
Compare
| # @param config [Agama::Storage::Configs::Partition] | ||
| # @return [Boolean] | ||
| def grow?(device, config) | ||
| return false unless config.size |
There was a problem hiding this comment.
NP: I would say #size cannot be nil.
| size_config.min = size | ||
| size_config.max = size | ||
| end | ||
| config.size = Agama::Storage::Configs::Size.new.tap do |size_config| |
There was a problem hiding this comment.
This will not be needed thanks to the solvers introduced by #1617. BTW, in general I am trying to generate configs from JSON hashes. I think it makes the tests easier to read and maintain.
ancorgs
added a commit
that referenced
this pull request
Sep 22, 2024
yast/yast-storage-ng#1388 introduced a change in the API of Y2Storage. Agama was adapted at #1599, but one particular conversion was left behind. This PR fixes that omission.
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Sep 23, 2024
https://build.opensuse.org/request/show/1202592 by user IGonzalezSosa + anag+factory - Storage: preliminary support for resizing partitions based on limits specified at the config (gh#agama-project/agama#1599). - Version 10 - Storage: add support for creating LVM volume groups and logical volumes (gh#agama-project/agama#1581).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
joseivanlopez#1 documented the approach to follow for resizing partitions at Agama, based on the partitioning config (a.k.a. the "profile").
The current pull request implements the basis of the described management.
It depends on the improvements introduced at yast2-storage-ng by yast/yast-storage-ng#1388
Pending
Some aspects of partition growing are not fully handled. That's planned for a future iteration and documented at https://trello.com/c/opInsicQ/531-storage-profile-partition-growing