-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update assets and refactor color schemes #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good. I love what you're done with the ColorScheme
enum.
Good luck integrating it with Storyboards though… 😬
struct SVGPair { | ||
let lightSVG: SVG | ||
let darkSVG: SVG | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering whether this name could be a little more descriptive of its intended use case. Possibly something like DynamicSVG
to reflect the dynamic colour terminology of iOS 13?
struct SVGPair { | |
let lightSVG: SVG | |
let darkSVG: SVG | |
} | |
struct DynamicSVG { | |
let light: SVG | |
let dark: SVG | |
} |
public enum ColorScheme { | ||
case `static`(ColorPalette) | ||
case dynamic(lightPalette: ColorPalette, darkPalette: ColorPalette) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
b5ea9fd
to
f64a222
Compare
11d895f
to
cd2915d
Compare
Summary of Changes
ColorScheme
and aColorPalette
Items of Note
File structure
Mint badge