Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assets and refactor color schemes #99

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Conversation

adamjcampbell
Copy link
Contributor

Summary of Changes

  • Adds new mint colour variants
  • Refactors colour variants to make use of a ColorScheme and a ColorPalette
  • Moves files into a more cohesive file structure

Items of Note

File structure

Screen Shot 2020-08-05 at 6 23 51 pm

Mint badge

Simulator Screen Shot - iPhone 11 Pro - 2020-08-05 at 18 19 15

@adamjcampbell adamjcampbell requested a review from Rypac as a code owner August 5, 2020 08:24
Copy link
Contributor

@Rypac Rypac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good. I love what you're done with the ColorScheme enum.

Good luck integrating it with Storyboards though… 😬

Comment on lines +135 to +138
struct SVGPair {
let lightSVG: SVG
let darkSVG: SVG
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether this name could be a little more descriptive of its intended use case. Possibly something like DynamicSVG to reflect the dynamic colour terminology of iOS 13?

Suggested change
struct SVGPair {
let lightSVG: SVG
let darkSVG: SVG
}
struct DynamicSVG {
let light: SVG
let dark: SVG
}

Comment on lines +11 to +13
public enum ColorScheme {
case `static`(ColorPalette)
case dynamic(lightPalette: ColorPalette, darkPalette: ColorPalette)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Base automatically changed from price-breakdown to master August 6, 2020 03:23
@adamjcampbell adamjcampbell merged commit 256c496 into master Aug 6, 2020
@adamjcampbell adamjcampbell deleted the update-assets branch August 6, 2020 03:35
@adamjcampbell adamjcampbell added the chore Project maintenance and hygiene label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Project maintenance and hygiene
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants