Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden Swiftlint build phase script to avoid build failures #80

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Harden Swiftlint build phase script to avoid build failures #80

merged 2 commits into from
Jul 21, 2020

Conversation

adamjcampbell
Copy link
Contributor

Summary of Changes

  • Quotes $SRCROOT to avoid path issues when running scripts
  • Opts not to run swiftlint when building for Carthage

Items of Note

This was discovered when trying to build with Carthage in a Test Projects directory and opts not to not run swiftlint when in a Carthage context.

@adamjcampbell adamjcampbell added the bug Something isn't working label Jul 21, 2020
@adamjcampbell adamjcampbell requested a review from Rypac July 21, 2020 07:15
@adamjcampbell adamjcampbell merged commit 51d331a into master Jul 21, 2020
@adamjcampbell adamjcampbell deleted the fix-carthage-build branch July 21, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rypac Rypac Awaiting requested review from Rypac

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adamjcampbell