Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EIT-697] Documentation: improvements based on developer feedback #227

Merged
merged 4 commits into from
Aug 29, 2022
Merged

[EIT-697] Documentation: improvements based on developer feedback #227

merged 4 commits into from
Aug 29, 2022

Conversation

ScottAntonacAP
Copy link
Collaborator

Summary of Changes

Better document the following

  • Redirect urls for checkout V1
  • popupOriginUrl property requirements for V2
  • shippingOptionDidChange completion

Submission Checklist

  • Documentation is changed or added.

benfterpay
benfterpay requested changes Aug 29, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@ScottAntonacAP @benfterpay
Update README.md
2acbb17 
Based on review feedback

Co-authored-by: Ben Firth <28610907+benfterpay@users.noreply.github.com>
@ScottAntonacAP ScottAntonacAP merged commit 0b60229 into master Aug 29, 2022
@ScottAntonacAP ScottAntonacAP deleted the docs/improve-clarity branch August 29, 2022 07:27
@ScottAntonacAP ScottAntonacAP mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfterpay benfterpay benfterpay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottAntonacAP @benfterpay