EIT-426: add intro text options to price breakdown #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwr
reviewed
Sep 2, 2021
| import Foundation | ||
|
|
||
| public enum AfterpayIntroText: String { | ||
| case NONE = "" |
There was a problem hiding this comment.
I think there's no reason for this to be SO SHOUTY. You can just use none, or if you're trying to avoid confusion with Optional.none you can use empty?
There was a problem hiding this comment.
It was more the fact that it's the only option that doesn't actually align with its value... but I agree - the style isn't great. Will update to empty.
There was a problem hiding this comment.
Addressed in 0a4e72a
huwr
reviewed
Sep 2, 2021
- change shouty NONE to empty - clean up template string for better readibility and easier maintenance of intro text options
huwr
reviewed
Sep 2, 2021
| @@ -35,7 +38,7 @@ struct PriceBreakdown { | |||
|
|
|||
| if let formattedPayment = formattedPayment, inRange { | |||
| badgePlacement = .end | |||
| string = String(format: Strings.fourPaymentsFormat, formattedPayment) | |||
| string = String(format: Strings.fourPaymentsFormat, introText.rawValue, formattedPayment).trimmingCharacters(in: .whitespaces) | |||
There was a problem hiding this comment.
Only thing I'd ask now is for you to please put a new line in to quash the swiftlint warning, please:
Suggested change
| string = String(format: Strings.fourPaymentsFormat, introText.rawValue, formattedPayment).trimmingCharacters(in: .whitespaces) | |
| string = String(format: Strings.fourPaymentsFormat, introText.rawValue, formattedPayment) | |
| .trimmingCharacters(in: .whitespaces) |
huwr
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
fourPaymentsFormatstringintroTexttoPriceBreakdownViewREADME.mdforintroTextoptionsSubmission Checklist
Screenshots
AfterpayIntroText.NONE
AfterpayIntroText.make
AfterpayIntroText.payInTitle