Add different kinds of payment buttons #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we just had one payment button. Now, we have a few more options for different wording.
Previously, there was a very big switch statement for finding the right SVG. This worked, but it is unsustainable as we add more different kinds of palettes and button kinds and locales. Now, we moved the logic for finding the SVG to the SVG struct itself. I have also moved SVG sources to new file. Before, all the SVG sources were in the SVG.swift file. This was too much for that file. I want to separate out the long, bland SVG source from the other logic in the SVG struct. This will be more important as we add more logic to the SVG struct.
k-obrien
approved these changes
May 10, 2021
It is flakey because it is using the real bootstrap and the real widget. We will have a better way to test this by using a mock bootstrap. Soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we just had one payment button. Now, we have a few more options for different wording.
Summary of Changes
Items of Note
It's not a massive change, but it gives merchants a few more options