Add options to cart screen #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7921e4c to
f1e9328
Compare
This will adjust the logic controller’s vision as to what the options need to be.
It only adjusts the ‘buy now’ option for now. It’s sends the `optionsChanged` event back to the logic controller via the event handler
Previously, we could only edit the “BuyNow” option on the cart screen, before checkout. Now, we have switches for all three options. The logic controller maintains the source of truth for the options. Event handlers update this source of source of truth via the logic controller’s `toggleOption(:)` function. That function takes a CheckoutV2Options key path, and toggles it.
f1e9328 to
ac7b025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add options to configure the
CheckoutV2Optionson the cart screen:Summary of Changes
CheckoutV2Optionsvalue.Items of Note
This will be handy, not just for testers, but for developers. It will be even handier when we get up to adding the deferred shipping options. We can use this, or a similar technique.
Submission Checklist
This change is only inside the Example app.