Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure currency formatting matches expected currency formatting #120

Merged
merged 7 commits into from
Oct 18, 2020
Merged

Ensure currency formatting matches expected currency formatting #120

merged 7 commits into from
Oct 18, 2020

Conversation

adamjcampbell
Copy link
Contributor

@adamjcampbell adamjcampbell commented Oct 16, 2020 •
edited
Loading

Summary of Changes

  • Removes Currency
  • Creates CurrencyFormatter
  • Updates formatting logic to match the Afterpay currency formatting rules

Items of Note

The rules here are derived from: https://js.sandbox.afterpay.com/index.html at the time of writing

Submission Checklist

  • Tests are included.
  • Documentation is changed or added.

@adamjcampbell adamjcampbell added the enhancement New feature or request label Oct 16, 2020
@adamjcampbell adamjcampbell requested a review from Rypac as a code owner October 16, 2020 07:14
Rypac
Rypac approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@Rypac Rypac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@adamjcampbell adamjcampbell merged commit 0f0db4d into master Oct 18, 2020
@adamjcampbell adamjcampbell deleted the currency-formatting branch October 18, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rypac Rypac Rypac approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjcampbell @Rypac