Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Update User Status Process #74

Merged
merged 37 commits into from
Jun 18, 2023

Conversation

Rapter1990
Copy link
Contributor

@Rapter1990 Rapter1990 commented Jun 11, 2023

What I have done so far is defined as shown below

1 ) Add userId to the claims for AysToken
2 ) Create UserSupportStatus enum class to define all cases for support status
3 ) Create UserSupportStatusUpdateRequest class to send this request to UserSupportStatusController
4 ) Implement Controller and Service for User Support Status
5 ) Write Junit tests for UserSupportStatusServiceImpl
6 ) Define Support Status to Liquibase
7 ) Write Integration test for UserSupportStatusControllerTest
8 ) Add this request to Postman Collection

@Rapter1990 Rapter1990 self-assigned this Jun 11, 2023
@Rapter1990 Rapter1990 added the feature New feature or request label Jun 11, 2023
@agitrubard agitrubard marked this pull request as draft June 11, 2023 19:26
@Rapter1990 Rapter1990 linked an issue Jun 11, 2023 that may be closed by this pull request
@Rapter1990 Rapter1990 added the in development This issue is being resolved label Jun 11, 2023
@Rapter1990 Rapter1990 requested a review from emreylmaz June 12, 2023 19:02
Copy link
Contributor

@emreylmaz emreylmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rapter1990 Rapter1990 added in review This issue in review and removed in development This issue is being resolved labels Jun 14, 2023
@agitrubard agitrubard marked this pull request as ready for review June 16, 2023 16:35
Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eline sağlık, geliştirmeler genel anlamda güzel ve okunaklı olmuş. Bir kaç düzeltme için yorumlarımı ekledim, onları düzelttikten sonra ben localimde akışı test ediyor olacam sonrasında merge edebiliriz.

Copy link
Contributor

@moaydogdu moaydogdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for transforming a tightly coupled code into a loosely coupled one.

@Rapter1990 Rapter1990 added done This issue has been resolved and removed in review This issue in review labels Jun 18, 2023
@agitrubard agitrubard merged commit 88e2e7b into main Jun 18, 2023
@agitrubard agitrubard deleted the features/44/user-update-support-status branch June 18, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done This issue has been resolved feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an user, I want to update my support status
6 participants