-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Update User Status Process #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eline sağlık, geliştirmeler genel anlamda güzel ve okunaklı olmuş. Bir kaç düzeltme için yorumlarımı ekledim, onları düzelttikten sonra ben localimde akışı test ediyor olacam sonrasında merge edebiliriz.
src/main/java/com/ays/user/controller/UserSupportStatusController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ays/user/model/dto/request/UserSupportStatusUpdateRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ays/user/model/dto/request/UserSupportStatusUpdateRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ays/user/service/UserSupportStatusService.java
Outdated
Show resolved
Hide resolved
src/test/java/com/ays/user/service/impl/UserSaveServiceImplTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for transforming a tightly coupled code into a loosely coupled one.
What I have done so far is defined as shown below
1 ) Add
userId
to the claims forAysToken
2 ) Create
UserSupportStatus
enum class to define all cases for support status3 ) Create
UserSupportStatusUpdateRequest
class to send this request toUserSupportStatusController
4 ) Implement
Controller
andService
forUser Support Status
5 ) Write
Junit tests
forUserSupportStatusServiceImpl
6 ) Define
Support Status
toLiquibase
7 ) Write
Integration test
forUserSupportStatusControllerTest
8 ) Add this
request
toPostman
Collection