Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose and README.md Files Have Been Refactored & MySQL Port Has Been Changed as 3307 #73

Merged
merged 5 commits into from
Jun 12, 2023

Conversation

agitrubard
Copy link
Collaborator

Bilgisayarında MySQL default olarak kurulu olabilmesi ihtimali sebebiyle MySQL portunu değiştirmekle uğraşmamak için 3307 portuna aldım ve bir kaç ufak düzeltme yaptım. README.md'deki .env kısmına da bizim kendi kurulumlarımızda yeni yapı sebebiyle ihtiyaç olmuyor.

@agitrubard agitrubard added the refactor Improvements to project label Jun 10, 2023
@agitrubard agitrubard added this to the v1.0.0 milestone Jun 10, 2023
@agitrubard agitrubard requested a review from emreylmaz June 10, 2023 14:27
@agitrubard agitrubard requested a review from burcubayik June 10, 2023 14:28
@emreylmaz emreylmaz self-requested a review June 11, 2023 14:01
Copy link
Contributor

@emreylmaz emreylmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eline emeğine sağlık ✨

Copy link
Contributor

@Rapter1990 Rapter1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rapter1990 Rapter1990 merged commit e9b24b1 into main Jun 12, 2023
@Rapter1990 Rapter1990 deleted the refactor/docker-compose-and-mysql-port branch June 12, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements to project
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants