Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure Logout Flows Have Been Created for Admin Users & Users #48

Merged
merged 89 commits into from
Jun 5, 2023
Merged

Secure Logout Flows Have Been Created for Admin Users & Users #48

merged 89 commits into from
Jun 5, 2023

Conversation

agitrubard
Copy link
Collaborator

@agitrubard agitrubard commented May 19, 2023 •
edited
Loading

This PR includes developments related to invalidating tokens used in secure logout flows for Admin Users and Other Users. With this development, users will be able to take secure logout action and invalidate their tokens.

Development Details:

  • Created the AYS_INVALID_TOKEN table to store the ID information of invalidated tokens.
  • As a result, repository and service layers were created to handle token invalidation, check if a token is valid, and perform these checks through the database.
  • The relevant service layer was integrated into the services used by Admin Users and Other Users, and endpoints were created.
  • Code refactoring was done in some classes.
  • JavaDoc was added for the added code.
  • Unit tests were written for the Controller and Service layers for the implemented changes.

agitrubard added 23 commits May 19, 2023 10:47
@agitrubard
AYS_INVALID_TOKEN Table DDLs Have Been Created
b9a0a74
@agitrubard
AysInvalidTokenEntity Class & AysInvalidTokenRepository Layer Hav…
9b38009 
…e Been Created
@agitrubard
AysInvalidTokenService Layer Has Been Created for Invalidate Token …
cc400fa 
…and Check Invalidity Of Token Flows
@agitrubard
AysInvalidTokenService Has Been Integrated to `AysBearerTokenAuthen…
96f0918 
…ticationFilter`
@agitrubard
AysTokenService.getAuthentication() Method Has Been Fixed
3aaabf7
@agitrubard
getAccessToken() Method Has Been Added to Identity Class
a646f5c
@agitrubard
TokenAlreadyInvalidatedException Class Has Been Created
04c3633
@agitrubard
AysTokenInvalidateRequest Class Has Been Created
2cb1371
@agitrubard
AdminUserAuthService.invalidateTokens() Method Has Been Created
6f67fbb
@agitrubard
Admin User Tokens Invalidate Endpoint Has Been Created
a46d059
@agitrubard
UserAuthService.invalidateTokens() Method Has Been Created
3b26afa
@agitrubard
User Tokens Invalidate Endpoint Has Been Created
12425e0
@agitrubard
Java DOC Has Been Added to AysInvalidTokenService Layer
80a3d17
@agitrubard
Java DOC Has Been Added to TokenAlreadyInvalidatedException Class
1366458
@agitrubard
Java DOC Has Been Added to `AdminUserAuthController.invalidateTokens(…
dc60fa5 
…)` Method
@agitrubard
Java DOC Has Been Added to UserAuthController.invalidateTokens() Me…
82723f3 
…thod
@agitrubard
Java DOC Has Been Added to AysInvalidTokenEntity Class
8777674
@agitrubard
Java DOC Has Been Added to AysInvalidTokenRepository Layer
f43a136
@agitrubard
Java DOC Has Been Added to UserAuthServiceImpl.invalidateTokens() M…
ea404b6 
…ethod
@agitrubard
Java DOC Has Been Added to `AdminUserAuthServiceImpl.invalidateTokens…
a16506c 
…()` Method
@agitrubard
Method Has Been Renamed
9bd050f
@agitrubard
Java DOC Has Been Added to AysTokenInvalidateRequest Class
331fc49
@agitrubard
Java DOC Has Been Added to AysIdentity.getAccessToken() Method
368f8a7
@agitrubard agitrubard requested a review from a team May 19, 2023 08:14
@agitrubard agitrubard marked this pull request as draft May 19, 2023 08:15
agitrubard added 25 commits June 4, 2023 20:12
@agitrubard
Java DOC Has Been Added to `AdminUserAuthServiceImpl.invalidateTokens…
0a07b7d 
…()` Method
@agitrubard
Method Has Been Renamed
6bd4ccd
@agitrubard
Java DOC Has Been Added to AysTokenInvalidateRequest Class
d66008c
@agitrubard
Java DOC Has Been Added to AysIdentity.getAccessToken() Method
861c5e7
@agitrubard
AYS Token Service Tests Have Been Fixed
8917727
@agitrubard
UserServiceImpl Class Has Been Refactored
c73887e
@agitrubard
User Tokens Invalidate Endpoint Has Been Covered with Unit Tests
4ff6328
@agitrubard
Admin User Auth Controller Tests Have Been Refactored
145158a
@agitrubard
Admin User Tokens Invalidate Endpoint Has Been Covered with Unit Tests
9636627
@agitrubard
User Auth Controller Tests Have Been Refactored
b7c7550
@agitrubard
Admin User Auth Controller Tests Have Been Refactored
2b43f4f
@agitrubard
User Auth Controller Tests Have Been Refactored
9721090
@agitrubard
User Controller Tests Have Been Refactored
a4995a3
@agitrubard
Object Has Been Renamed
bb87bef
@agitrubard
AysTokenBuilder.getValidClaims() Method Has Been Updated
635fe5e
@agitrubard
mockAdminUserToken and mockUserToken Objects Have Been Updated in…
9d5d05f 
… `AbstractUnitTest` Abstract Class
@agitrubard
AdminUserAuthService.invalidateTokens() Method Has Been Refactored
6b7a77f
@agitrubard
UserAuthService.invalidateTokens() Method Has Been Refactored
e4b2e0c
@agitrubard
AdminUserAuthService.invalidateTokens() Method Has Been Covered wit…
49530fc 
…h Unit Tests
@agitrubard
UserAuthService.invalidateTokens() Method Has Been Covered with Uni…
0ae788f 
…t Tests
@agitrubard
AysInvalidTokenService.invalidateTokens() Method Has Been Covered w…
69ec178 
…ith Unit Test
@agitrubard
AysInvalidTokenService.checkForInvalidityOfToken() Method Has Been …
1246c63 
…Covered with Unit Tests
@agitrubard
Code Refactor for @Transactional Annotation
890ed78
@agitrubard
Changes Have Been Reflected Considering Review Comments
56d120b
@agitrubard
Merge remote-tracking branch 'origin/feature/logout-for-user-and-admi…
becc2c3 
…n-user' into feature/logout-for-user-and-admin-user

# Conflicts:
#	src/test/java/com/ays/user/controller/UserControllerTest.java
Rapter1990 added 2 commits June 5, 2023 21:40
@Rapter1990
Merge remote-tracking branch 'origin/main' into feature/logout-for-us…
9d00642 
…er-and-admin-user

# Conflicts:
#	src/main/java/com/ays/auth/model/AysIdentity.java
#	src/test/java/com/ays/admin_user/controller/AdminUserAuthControllerTest.java
@Rapter1990
Revise AdminUserAuthControllerTest, AdminUserControllerTest, AysError…
96d9f63 
…Builder, AysIdentity and UserAuthControllerTest
@Rapter1990 Rapter1990 merged commit be171e2 into main Jun 5, 2023
@Rapter1990 Rapter1990 deleted the feature/logout-for-user-and-admin-user branch June 5, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skayikci skayikci skayikci approved these changes

@Rapter1990 Rapter1990 Rapter1990 approved these changes

Assignees

@agitrubard agitrubard

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@agitrubard @skayikci @Rapter1990