Implementation of showing all administrators through admin panel #46

Rapter1990 · 2023-05-15T19:17:00Z

Implementation of showing all administrators through admin panel

src/main/java/com/ays/admin_user/service/impl/AdminUserServiceImpl.java

skayikci · 2023-05-16T20:26:05Z

Thank you for the PR, could you also update the postman collection?

…ServiceImpl

src/main/java/com/ays/admin_user/controller/AdminUserController.java

src/main/java/com/ays/admin_user/model/AdminUser.java

src/main/java/com/ays/admin_user/model/mapper/AdminEntityToAdminUserMapper.java

src/main/java/com/ays/admin_user/repository/AdminUserRepository.java

src/main/java/com/ays/admin_user/service/AdminUserService.java

src/main/java/com/ays/admin_user/service/impl/AdminUserServiceImpl.java

src/main/java/com/ays/admin_user/util/exception/AysAdminUserNotFoundException.java

src/main/java/com/ays/auth/model/enums/AysUserType.java

agitrubard · 2023-05-17T16:19:16Z

@Rapter1990 Since a PR is already associated with an issue, can we remove it from the GitHub Project Board by deleting the project section?

…ceImpl

…minUserServiceImplTest

src/main/java/com/ays/admin_user/service/AdminUserService.java

src/main/java/com/ays/admin_user/service/impl/AdminUserServiceImpl.java

src/main/java/com/ays/auth/model/AysIdentity.java

… AysIdentity

… and AysIdentity

src/main/java/com/ays/admin_user/service/impl/AdminUserServiceImpl.java

src/main/java/com/ays/admin_user/service/AdminUserService.java

src/test/java/com/ays/admin_user/controller/AdminUserControllerTest.java

src/test/java/com/ays/admin_user/service/impl/AdminUserServiceImplTest.java

src/test/java/com/ays/admin_user/controller/AdminUserControllerTest.java

src/test/java/com/ays/admin_user/service/impl/AdminUserServiceImplTest.java

…ControllerTest

src/test/java/com/ays/admin_user/service/impl/AdminUserServiceImplTest.java

…ServiceImplTest

src/test/java/com/ays/util/AysMockResultMatchersBuilders.java

src/test/java/com/ays/admin_user/service/impl/AdminUserServiceImplTest.java

src/main/resources/db/changelog/changes/2-ays-dml.xml

src/test/java/com/ays/admin_user/controller/AdminUserAuthControllerTest.java

src/test/java/com/ays/admin_user/controller/AdminUserControllerTest.java

…inUsers method of AdminUserServiceImplTest

src/main/resources/db/changelog/changes/2-ays-dml.xml

…rviceImplTest and AdminUserServiceImplTest.java

…minUserControllerTest and AdminUserAuthControllerTest

src/test/java/com/ays/admin_user/controller/AdminUserAuthControllerTest.java

Implementation of showing all administrators through admin panel

3381455

Rapter1990 added the feature New feature or request label May 15, 2023

Rapter1990 self-assigned this May 15, 2023

Rapter1990 linked an issue May 15, 2023 that may be closed by this pull request

As an admin, I want to view all administrator users through the admin panel. #28

Closed

agitrubard requested review from skayikci and agitrubard May 15, 2023 19:23

Rapter1990 added 3 commits May 16, 2023 00:24

Add UnAuthorized Test for AdminUserControllerTest

668ccd7

Add more information for Java Doc in AdminUserController

341a61d

Add more information for Java Doc in AdminUserServiceImpl

e7268b5

skayikci reviewed May 16, 2023

View reviewed changes

src/main/java/com/ays/admin_user/service/impl/AdminUserServiceImpl.java Outdated Show resolved Hide resolved

Rapter1990 added 2 commits May 16, 2023 23:51

Add SUPER_ADMIN to AysUserType

eeba3fd

Revise the code for getting username in getAllAdminUsers of AdminUser…

ce90618

…ServiceImpl

agitrubard requested changes May 17, 2023

View reviewed changes

Rapter1990 added 7 commits May 17, 2023 20:35

Create AdminUserListRequest and AdminUserListRequestBuilder

b6fd69a

Revise codes in AdminUserController, AdminUserService, AdminUserServi…

d27a099

…ceImpl

Revise codes in AdminUserControllerTest and AdminUserServiceImplTest

5d5e8d5

Change the class name as AdminUserEntityToAdminUserMapper

c4b9d57

Revise codes for AdminUserControllerTest, AdminUserServiceImpl and Ad…

501695f

…minUserServiceImplTest

Revise codes in AysIdentity

151507b

Revise codes in AdminUserServiceImpl and AdminUserServiceImplTest

4614d1b

Rapter1990 requested review from skayikci and agitrubard May 17, 2023 19:11

agitrubard requested changes May 18, 2023

View reviewed changes

Rapter1990 added 5 commits May 18, 2023 20:04

Revise codes in AdminUserServiceImpl and AdminUserServiceImplTest for…

b2c05a8

… AysIdentity

Fix user type issue in AdminUserServiceImpl, AdminUserServiceImplTest…

a053231

… and AysIdentity

Revise exception type in AdminUserServiceImpl

8d7e9df

Add Java Doc for AysIdentity

6df8dcc

Revise Java Doc for AdminUserService

3055d97

agitrubard reviewed May 26, 2023

View reviewed changes

src/main/java/com/ays/admin_user/service/impl/AdminUserServiceImpl.java Outdated Show resolved Hide resolved

afet-yonetim-sistemi deleted a comment from Rapter1990 May 26, 2023

agitrubard requested changes May 26, 2023

View reviewed changes

Rapter1990 added 5 commits May 26, 2023 14:29

Add methods for andExpect process in Integration Test

754ca43

Revise AdminUserService and AdminUserServiceImplTest

a79a2f3

Revise AdminUserAuthControllerTest, AdminUserController and AdminUser…

cb7e9e3

…ControllerTest

Add admin with its role SUPER_ADMIN in ddl for liquibase

7ada250

Revise AdminUserServiceImpl

5a2ce2d

agitrubard removed this from the v1.0.0 milestone May 28, 2023

Rapter1990 requested a review from agitrubard May 29, 2023 20:32

Revise AdminUserControllerTest

31814d1

agitrubard reviewed May 30, 2023

View reviewed changes

src/test/java/com/ays/admin_user/service/impl/AdminUserServiceImplTest.java Outdated Show resolved Hide resolved

Add static keyword to mapper in AdminUserControllerTest and AdminUser…

442be52

…ServiceImplTest

agitrubard requested changes May 30, 2023

View reviewed changes

Rapter1990 added 4 commits May 30, 2023 22:02

Revise givenUserListRequest_whenAdminwithRoleIsAdmin_thenReturnAllAdm…

7316ca4

…inUsers method of AdminUserServiceImplTest

Revise 2-ays-dml.xml

7543326

Revise AysMockResultMatchersBuilders

1e162d4

Delete AysAdminUserNotFoundException

2c5ee0c

Rapter1990 commented May 30, 2023

View reviewed changes

src/main/resources/db/changelog/changes/2-ays-dml.xml Outdated Show resolved Hide resolved

Rapter1990 requested a review from agitrubard June 1, 2023 12:24

Rapter1990 added 2 commits June 4, 2023 20:38

Add one blank end of the AdminUserControllerTest, AdminUserRegisterSe…

4f37582

…rviceImplTest and AdminUserServiceImplTest.java

Revise AdminUserServiceImplTest, AdminUserRegisterServiceImplTest, Ad…

0e39778

…minUserControllerTest and AdminUserAuthControllerTest

agitrubard approved these changes Jun 5, 2023

View reviewed changes

src/test/java/com/ays/admin_user/controller/AdminUserAuthControllerTest.java Outdated Show resolved Hide resolved

Rapter1990 added 2 commits June 5, 2023 19:42

Revise AdminUserAuthControllerTest and AdminUserControllerTest

78f33e7

Revise AdminUserAuthControllerTest and AysMockResultMatchersBuilders

a5dabe6

skayikci approved these changes Jun 5, 2023

View reviewed changes

Rapter1990 merged commit 50ee038 into main Jun 5, 2023

Rapter1990 deleted the features/adminusers branch June 5, 2023 18:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of showing all administrators through admin panel #46

Implementation of showing all administrators through admin panel #46

Rapter1990 commented May 15, 2023

skayikci commented May 16, 2023

agitrubard commented May 17, 2023

Implementation of showing all administrators through admin panel #46

Implementation of showing all administrators through admin panel #46

Conversation

Rapter1990 commented May 15, 2023

skayikci commented May 16, 2023

agitrubard commented May 17, 2023