AYS-644 | Allow Only Country Code 90 for User Registration #439
Conversation
|
@gunesakkayaa checklist'in formatı bozulmuş, buna dikkat edebilir miyiz? |
| @@ -17,6 +18,7 @@ public class AysPhoneNumberRequest { | |||
| * The country code of the phone number | |||
| */ | |||
| @NotBlank | |||
| @Pattern(regexp = "90", message = "Currently, only 90 country code is allowed.") | |||
There was a problem hiding this comment.
Bu kısmı @PhoneNumber validasyonunun içerisine eklersek daha iyi olabilir ✅
There was a problem hiding this comment.
@gunesakkayaa bir de bu düzenlemeyle ilgili testler de ekleyebilir miyiz?
There was a problem hiding this comment.
@gunesakkayaa @PhoneNumber validasyonuna eklediysen buradan kaldırabilirsin
| @@ -12,6 +13,8 @@ | |||
| */ | |||
| class PhoneNumberValidator implements ConstraintValidator<PhoneNumber, AysPhoneNumberRequest> { | |||
|
|
|||
| @Pattern(regexp = "90", message = "Currently, only 90 country code is allowed.") | |||
There was a problem hiding this comment.
@gunesakkayaa burayı diğer validasyonlardakine benzer bir formata çevirebilir
misin ve testler eksik onları da ekleyebilir misin
There was a problem hiding this comment.
tamamdır, ilgileniyorum
src/main/java/org/ays/common/util/validation/PhoneNumberValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ays/common/util/validation/PhoneNumberValidator.java
Outdated
Show resolved
Hide resolved
| // Verify | ||
| Mockito.verify(adminRegistrationCompleteService, Mockito.never()) | ||
| .complete(Mockito.anyString(), Mockito.any()); | ||
| } |
There was a problem hiding this comment.
Bu teste benzer testleri Phone Number'ın kullanıldığı başka yerlere de ekleyebilir miyiz
…k and the if check was done as desired
…y Evacuation Application should not have a value other than "90"
Checklist
Before submitting your pull request, ensure the following:
Title and Branch Naming Conventions:
standard: Pull Request Naming Conventions.
the Branch Naming Conventions.
Local Testing:
Code Quality:
Documentation:
Testing:
Reviewers and Assignees:
Labels and Associations: