Get User(s) Implementation #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agitrubard
previously requested changes
Mar 2, 2023
src/main/java/com/ays/backend/user/controller/UserController.java
Outdated
Show resolved
Hide resolved
src/test/java/com/ays/backend/user/model/entities/UserBuilder.java
Outdated
Show resolved
Hide resolved
src/test/java/com/ays/backend/user/service/dto/UserDTOBuilder.java
Outdated
Show resolved
Hide resolved
src/test/java/com/ays/backend/user/controller/UserControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/ays/backend/user/service/UserServiceTest.java
Outdated
Show resolved
Hide resolved
skayikci
approved these changes
Mar 4, 2023
skayikci
approved these changes
Mar 4, 2023
agitrubard
requested changes
Mar 5, 2023
There was a problem hiding this comment.
@Rapter1990 My comment is small, we can merge it after resolving it.
src/main/java/com/ays/backend/user/service/impl/UserServiceImpl.java
Outdated
Show resolved
Hide resolved
agitrubard
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done is based on the implementation of all processes shown below.
1 ) Get User process with its controller and service test
2 ) Get User By Id with its controller and service test