Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#148 | Implementation of 'Update Assignment' API Endpoint #169

Merged
merged 18 commits into from
Sep 13, 2023
Merged

#148 | Implementation of 'Update Assignment' API Endpoint #169

merged 18 commits into from
Sep 13, 2023

Conversation

AhmetAksunger
Copy link
Contributor

PULL REQUEST TEMPLATE

Implemented the Update Assignment endpoint

Please provide a brief description of the changes made in this pull request.

Related Issue

#148

If this pull request is related to any GitHub issue, please mention it here with the appropriate issue number.

Proposed Changes

Please provide a brief and descriptive title for your pull request, summarizing the changes or features introduced. It
should be in English and clearly indicate the purpose of the pull request. Optionally, you can provide a more detailed
description of what you have done.

  • Branches should follow the below Naming Conventions of Branchs header in README.md File

Additional Information

If there's any additional information or context that the reviewers should know, please provide it here.

Checklist

Please check the following before submitting your pull request:

  • I have tested my changes locally and they are working as expected.
  • The code is formatted according to the project's coding guidelines and style.
  • Necessary documentation has been added or existing documentation has been updated.
  • Relevant unit tests have been written and included.
  • Relevant integration tests have been written and included.
  • The code has been reviewed to ensure its quality.
  • The code does not contain any issues flagged by SonarLint.
  • Default reviewers have been assigned to this pull request.
  • Assignees have been added if necessary.
  • Labels have been applied if necessary.
  • If an issue is opened and this pull request is related to that issue, it should not be associated with any project
    board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
    board (BE Board, In Review column) and milestone to track the progress.

Reviewers

The default project maintainers and team members will be automatically assigned as reviewers for this pull request.

@AhmetAksunger
Create AssignmentUpdateRequest
9b5da35
@AhmetAksunger
Add updateAssignment method to AssignmentService
d07d6f4
@AhmetAksunger
Implement updateAssignment method in AssignmentServiceImpl
5371fda
@AhmetAksunger
Add updateAssignment method to AssignmentEntity
0a80057
@AhmetAksunger
Add updateAssignment method to AssignmentController
5ae04ac
@AhmetAksunger
Merge remote-tracking branch 'origin/main' into feature/148/update-as…
d1266e7 
…signment

# Conflicts:
#	src/main/java/com/ays/assignment/controller/AssignmentController.java
#	src/main/java/com/ays/assignment/service/AssignmentService.java
#	src/main/java/com/ays/assignment/service/impl/AssignmentServiceImpl.java
@AhmetAksunger
Create AssignmentUpdateRequestBuilder
530c884
@AhmetAksunger
Update updateAssignment method in AssignmentEntity
a2fea45
@AhmetAksunger
Change the field values in AssignmentUpdateRequestBuilder
5d21c65
@AhmetAksunger
Handle givenValidAssignmentIdAndAssignmentUpdateRequest_whenAssignmen…
77c0c4d 
…tAvailable_thenUpdateAssignment
@AhmetAksunger
Handle givenValidAssignmentIdAndAssignmentUpdateRequest_whenAssignmen…
93ab4ec 
…tNotAvailable_thenThrowAysAssignmentNotExistByIdException
@AhmetAksunger
Handle givenValidAssignmentIdAndAssignmentUpdateRequest_whenAssignmen…
bcc4ec7 
…tNotExists_thenThrowAysAssignmentNotExistByIdException
@AhmetAksunger
Handle givenValidAssignmentIdAndAssignmentUpdateRequest_whenAssignmen…
63cc975 
…tUpdated_thenReturnAysResponseOfSuccess & givenValidAssignmentIdAndAssignmentUpdateRequest_whenUserUnauthorizedForUpdating_thenThrowAccessDeniedException
@AhmetAksunger
Handle end-to-end tests
3644ba9
@AhmetAksunger
Reformat
d956729
@AhmetAksunger AhmetAksunger self-assigned this Sep 9, 2023
@AhmetAksunger AhmetAksunger mentioned this pull request Sep 9, 2023
Merged
11 tasks
@AhmetAksunger AhmetAksunger linked an issue Sep 9, 2023 that may be closed by this pull request
Atama Güncelleme Servisinin Hazırlanması #148
Closed
skayikci
skayikci previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@skayikci skayikci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@agitrubard agitrubard self-requested a review September 13, 2023 09:53
@agitrubard agitrubard merged commit fbee71e into main Sep 13, 2023
@agitrubard agitrubard deleted the feature/148/update-assignment branch September 13, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agitrubard agitrubard agitrubard approved these changes

@artfulCoder98 artfulCoder98 artfulCoder98 approved these changes

@Rapter1990 Rapter1990 Awaiting requested review from Rapter1990

@ibrahimdenizz ibrahimdenizz Awaiting requested review from ibrahimdenizz

@moaydogdu moaydogdu Awaiting requested review from moaydogdu

@ilkerCelimli ilkerCelimli Awaiting requested review from ilkerCelimli

@anilhazar anilhazar Awaiting requested review from anilhazar

@skayikci skayikci Awaiting requested review from skayikci skayikci is a code owner

Assignees

@AhmetAksunger AhmetAksunger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atama Güncelleme Servisinin Hazırlanması
4 participants
@AhmetAksunger @skayikci @agitrubard @artfulCoder98