Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#94 | Implement the process of getting Assignment by ID #156

Merged
merged 16 commits into from
Aug 28, 2023
Merged

#94 | Implement the process of getting Assignment by ID #156

merged 16 commits into from
Aug 28, 2023

Conversation

Rapter1990
Copy link
Contributor

@Rapter1990 Rapter1990 commented Aug 25, 2023 •
edited by moaydogdu
Loading

PULL REQUEST TEMPLATE

Description

  • Implement the process of getting Assignment by Id

Related Issue

If this pull request is related to any GitHub issue, please mention it here with the appropriate issue number.

Proposed Changes

Please provide a brief and descriptive title for your pull request, summarizing the changes or features introduced. It
should be in English and clearly indicate the purpose of the pull request. Optionally, you can provide a more detailed
description of what you have done.

  • Branches should follow the below Naming Conventions of Branchs header in README.md File

Additional Information

If there's any additional information or context that the reviewers should know, please provide it here.

Checklist

Please check the following before submitting your pull request:

  • I have tested my changes locally and they are working as expected.
  • The code is formatted according to the project's coding guidelines and style.
  • Necessary documentation has been added or existing documentation has been updated.
  • Relevant unit tests have been written and included.
  • Relevant integration tests have been written and included.
  • The code has been reviewed to ensure its quality.
  • The code does not contain any issues flagged by SonarLint.
  • Default reviewers have been assigned to this pull request.
  • Assignees have been added if necessary.
  • Labels have been applied if necessary.
  • If an issue is opened and this pull request is related to that issue, it should not be associated with any project
    board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
    board (BE Board, In Review column) and milestone to track the progress.

Reviewers

The default project maintainers and team members will be automatically assigned as reviewers for this pull request.

@Rapter1990
Define AssignmentService
b9a5a59
@Rapter1990
Define getAssignmentById method in AssignmentController
aab7436
@Rapter1990
Define findByIdAndInstitutionId in AssignmentRepository
1bbef11
@Rapter1990
Define getAssignmentById in AssignmentServiceImpl
8fd3038
@Rapter1990
Define getAssignmentById in AssignmentController
1d41af5
@Rapter1990
Update getAssignmentById in AssignmentController
ad2ac21
@Rapter1990
Define AssignmentServiceImpl as package-private
eba5aca
@Rapter1990
Define AssignmentServiceImplTest
d8adea4
@Rapter1990
Add givenAssignmentId_whenAssignmentNotFound_thenThrowAysAssignmentNo…
c9cf89a 
…tExistByIdException in AssignmentServiceImplTest
@Rapter1990
Revise Request method for getting assignment by id in AssignmentContr…
033aa9a 
…oller
@Rapter1990
Add givenValidAssignmentId_whenAssignmentFound_thenReturnAssignmentRe…
db5f25b 
…sponse and givenValidAssignmentId_whenUnauthorizedForGettingAssignmentById_thenReturnAccessDeniedException in AssignmentControllerTest
@Rapter1990
Implement end-to-end test for getting assignment by id
7e68b31
@AhmetAksunger AhmetAksunger marked this pull request as draft August 26, 2023 07:45
@Rapter1990 Rapter1990 marked this pull request as ready for review August 26, 2023 16:11
@agitrubard agitrubard linked an issue Aug 27, 2023 that may be closed by this pull request
Atama Detay Servisinin Hazırlanması #94
Closed
@AhmetAksunger AhmetAksunger changed the title #93 | Implement the process of getting Assignment by ID #94 | Implement the process of getting Assignment by ID Aug 28, 2023
moaydogdu
moaydogdu approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@moaydogdu moaydogdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agitrubard agitrubard merged commit e157d7d into main Aug 28, 2023
@agitrubard agitrubard deleted the feature/94/get-assignment-by-id branch August 28, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agitrubard agitrubard agitrubard approved these changes

@moaydogdu moaydogdu moaydogdu approved these changes

@skayikci skayikci Awaiting requested review from skayikci skayikci is a code owner

@burcubayik burcubayik Awaiting requested review from burcubayik

@emreylmaz emreylmaz Awaiting requested review from emreylmaz

@anilhazar anilhazar Awaiting requested review from anilhazar

@enig enig Awaiting requested review from enig

@artfulCoder98 artfulCoder98 Awaiting requested review from artfulCoder98

Assignees

@Rapter1990 Rapter1990

@AhmetAksunger AhmetAksunger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atama Detay Servisinin Hazırlanması
4 participants
@Rapter1990 @agitrubard @moaydogdu @AhmetAksunger