-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-compose.yml and k8s deployment.yaml and service.yaml files #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- there's a problem regarding the java image that we use here, the problem is:
it is not able to load for macbook pro with M1 chips.
Therefore we need to use this version: azul/zulu-openjdk:17 in order to comply with those kind of machines. Here is the error that i'm having:
=> ERROR [internal] load metadata for docker.io/library/eclipse-temurin:17-jdk-alpine 1.8s
[internal] load metadata for docker.io/library/eclipse-temurin:17-jdk-alpine:
failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: no match for platform in manifest sha256:b99f9457ad5cabdfa02935d1048082dd79d318685cfa0ca79a8f623c052c406a: not found
-
secondly, do we want to load the whole database locally? Or we can just switch to h2 locally, as we talked before, if so, then we need to switch the profile to dev: "SPRING_PROFILES_ACTIVE=dev".
-
third point is about the folder structure, all the files are under the root folder, and for different kind of profiles, we won't have the possibility to change it when we don't have different files for those envs.
|
@skayikci i've added spring profiles to docker-compose.yaml, if it looks good to you, we can merge and i can tackle env separation for k8s in a seperate PR after backend agrees on the tool to use |
Could you also add the image that fixes the problem with m1 chips? I opened the pr to test something. |
@skayikci sure, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
These files can both be used for local development and deployment to the cloud.