Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose.yml and k8s deployment.yaml and service.yaml files #15

Merged
merged 6 commits into from
Mar 4, 2023

Conversation

halilturkoglucs
Copy link
Contributor

@halilturkoglucs halilturkoglucs commented Feb 24, 2023

These files can both be used for local development and deployment to the cloud.

@halilturkoglucs halilturkoglucs requested a review from a team as a code owner February 24, 2023 11:30
Copy link
Collaborator

@skayikci skayikci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • there's a problem regarding the java image that we use here, the problem is:
    it is not able to load for macbook pro with M1 chips.
    Therefore we need to use this version: azul/zulu-openjdk:17 in order to comply with those kind of machines. Here is the error that i'm having:
    => ERROR [internal] load metadata for docker.io/library/eclipse-temurin:17-jdk-alpine 1.8s

[internal] load metadata for docker.io/library/eclipse-temurin:17-jdk-alpine:
failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: no match for platform in manifest sha256:b99f9457ad5cabdfa02935d1048082dd79d318685cfa0ca79a8f623c052c406a: not found


  • secondly, do we want to load the whole database locally? Or we can just switch to h2 locally, as we talked before, if so, then we need to switch the profile to dev: "SPRING_PROFILES_ACTIVE=dev".

  • third point is about the folder structure, all the files are under the root folder, and for different kind of profiles, we won't have the possibility to change it when we don't have different files for those envs.

@halilturkoglucs
Copy link
Contributor Author

halilturkoglucs commented Feb 25, 2023

  1. I think you fixed it with another pr, so it should work fine now.
  2. Hmm, it may depend on the situation but normally mysql db should be considered (for docker compose case), other in-mem solutions may not be indicated in k8s or compose files. So maybe here we can add active profile config to .env.local instead of making it dynamic, ill make this change.
  3. I think for now root dir is the convention. However i do agree that these files may be configurable depending on the env. So, i propose tackling this with another pr which should add helm or kustomize k8s templating solutions. For this, we need to also first agree on using helm or another tool

@halilturkoglucs
Copy link
Contributor Author

@skayikci i've added spring profiles to docker-compose.yaml, if it looks good to you, we can merge and i can tackle env separation for k8s in a seperate PR after backend agrees on the tool to use

@skayikci
Copy link
Collaborator

skayikci commented Mar 4, 2023

Could you also add the image that fixes the problem with m1 chips? I opened the pr to test something.

@halilturkoglucs
Copy link
Contributor Author

@skayikci sure, done

Copy link
Collaborator

@skayikci skayikci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@halilturkoglucs halilturkoglucs merged commit fff112d into main Mar 4, 2023
@halilturkoglucs halilturkoglucs deleted the feature/compose_and_k8s branch March 4, 2023 17:33
@agitrubard agitrubard added this to the v1.0.0 milestone May 23, 2023
@agitrubard agitrubard added the feature New feature or request label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants