Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#115 | Refactor Admin Default Role #121

Merged
merged 1 commit into from
Jul 13, 2023
Merged

#115 | Refactor Admin Default Role #121

merged 1 commit into from
Jul 13, 2023

Conversation

Rapter1990
Copy link
Contributor

@Rapter1990 Rapter1990 commented Jul 9, 2023 •
edited
Loading

PULL REQUEST TEMPLATE

Description

Fix Admin Default Role Issue

Related Issue

In the Admin Registration flow, as the mapping of data cannot contain the request to the ROLE field in the AdminUserEntity object, it is necessary to assign the default value as ADMIN.

Proposed Changes

Please provide a brief and descriptive title for your pull request, summarizing the changes or features introduced. It
should be in English and clearly indicate the purpose of the pull request. Optionally, you can provide a more detailed
description of what you have done.

  • refactor/115/add-admin-default-role

Additional Information

If there's any additional information or context that the reviewers should know, please provide it here.

Checklist

Please check the following before submitting your pull request:

  • I have tested my changes locally and they are working as expected.
  • The code is formatted according to the project's coding guidelines and style.
  • Necessary documentation has been added or existing documentation has been updated.
  • Relevant unit tests have been written and included.
  • Relevant integration tests have been written and included.
  • The code has been reviewed to ensure its quality.
  • The code does not contain any issues flagged by SonarLint.
  • Default reviewers have been assigned to this pull request.
  • Assignees have been added if necessary.
  • Labels have been applied if necessary.
  • If an issue is opened and this pull request is related to that issue, it should not be associated with any project
    board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
    board (BE Board, In Review column) and milestone to track the progress.

Reviewers

The default project maintainers and team members will be automatically assigned as reviewers for this pull request.

@Rapter1990 Rapter1990 self-assigned this Jul 9, 2023
@Rapter1990 Rapter1990 added refactor Improvements to project in review This issue in review labels Jul 9, 2023
@Rapter1990 Rapter1990 linked an issue Jul 9, 2023 that may be closed by this pull request
Admin Kayıt Akışında Default Role Belirlenmeli #115
Closed
@Rapter1990 Rapter1990 changed the title Refactor Admin Default Role #115 | Refactor Admin Default Role Jul 10, 2023
@agitrubard agitrubard removed the in review This issue in review label Jul 12, 2023
agitrubard
agitrubard approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kodlarda bir sorun görünmüyor, eline sağlık temiz olmuş ✅

Postman üzerindeki manuel testlerimizi de yapalım, hata olmadığından emin olalım.

moaydogdu
moaydogdu approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@moaydogdu moaydogdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agitrubard agitrubard merged commit b797e1d into main Jul 13, 2023
@agitrubard agitrubard deleted the refactor/115/add-admin-default-role branch July 13, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skayikci skayikci skayikci approved these changes

@agitrubard agitrubard agitrubard approved these changes

@moaydogdu moaydogdu moaydogdu approved these changes

@emreylmaz emreylmaz Awaiting requested review from emreylmaz

@ilkerCelimli ilkerCelimli Awaiting requested review from ilkerCelimli

@artfulCoder98 artfulCoder98 Awaiting requested review from artfulCoder98

Assignees

@Rapter1990 Rapter1990

Labels
refactor Improvements to project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin Kayıt Akışında Default Role Belirlenmeli
4 participants
@Rapter1990 @skayikci @agitrubard @moaydogdu