Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguous Mapping Error Has Been Fixed #109

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Ambiguous Mapping Error Has Been Fixed #109

merged 1 commit into from
Jul 1, 2023

Conversation

agitrubard
Copy link
Collaborator

No description provided.

@agitrubard agitrubard added bug Something isn't working in development This issue is being resolved labels Jun 30, 2023
@agitrubard agitrubard added this to the v1.0.0 milestone Jun 30, 2023
@agitrubard agitrubard self-assigned this Jun 30, 2023
@agitrubard agitrubard changed the title Ambiguous Mapping Error Has Been Fixed and Endpoints Have Been Updated Ambiguous Mapping Error Has Been Fixed Jun 30, 2023
ilkerCelimli
ilkerCelimli reviewed Jul 1, 2023
View reviewed changes
Copy link
Contributor

@ilkerCelimli ilkerCelimli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefixleri, class başında /api/v1/admin veya api/v1/user şeklinde versek çok daha iyi olmaz mıydı ? class okulanabilirliği açısından

@agitrubard
Copy link
Collaborator Author

prefixleri, class başında /api/v1/admin veya api/v1/user şeklinde versek çok daha iyi olmaz mıydı ? class okulanabilirliği açısından

Okunabilirliği düşürdüğünü düşünmüyorum fakat şöyle bir durum var ki; listeleme isteğini /users olarak güncelledim çünkü kaydetme isteği de POST HTTP Methodunu kullandığı için çakışıyordu.

@ilkerCelimli ilkerCelimli self-requested a review July 1, 2023 17:13
@agitrubard agitrubard merged commit e4e6af3 into main Jul 1, 2023
@agitrubard agitrubard deleted the hotfix/ambigous-mapping branch July 1, 2023 20:07
@agitrubard agitrubard added done This issue has been resolved and removed in development This issue is being resolved labels Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skayikci skayikci skayikci approved these changes

@ilkerCelimli ilkerCelimli ilkerCelimli approved these changes

@emreylmaz emreylmaz Awaiting requested review from emreylmaz

@MertYilmaz41 MertYilmaz41 Awaiting requested review from MertYilmaz41

@moaydogdu moaydogdu Awaiting requested review from moaydogdu

@burcubayik burcubayik Awaiting requested review from burcubayik

@Rapter1990 Rapter1990 Awaiting requested review from Rapter1990

Assignees

@agitrubard agitrubard

Labels
bug Something isn't working done This issue has been resolved
Projects
No open projects
AYS | Back-End Board
Status: Done
Milestone
v1.0.0.MVP
Development

Successfully merging this pull request may close these issues.
3 participants
@agitrubard @skayikci @ilkerCelimli