#75 | Private and Public Keys Have Been Encrypted & Flows and Tests Have Been Refactored #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… & Keys Have Been Integrated to Flow
skayikci
reviewed
Jun 25, 2023
ilkerCelimli
approved these changes
Jun 26, 2023
Rapter1990
reviewed
Jun 26, 2023
Rapter1990
reviewed
Jul 3, 2023
@Rapter1990 What kind of description did we need to make? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the private and public keys used for token generation were openly stored in the database. Due to the potential security vulnerability, it was considered more appropriate to hash these keys and store them in the database. To address this issue, a private repository was created specifically for the purpose of hashing operations. Within this repository, hashing workflows were developed to ensure that the hashing process is not directly accessible from external sources. Subsequently, this library was integrated into the backend project. After the integration, the workflows were updated, and the keys are now stored in a hashed form, rather than being openly accessible. The database scripts were also updated accordingly.