Landing page #929
Merged
Landing page #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
approved these changes
Dec 16, 2020
0b32874 to
343b12c
Compare
d1d4e9a to
e9c200a
Compare
|
Is this still a WIP? @venimus can you check why the CI is failing? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@venimus any update on this? |
ef5b814 to
b242a18
Compare
|
Deployed to landing-page.aggregator.z52da5wt.xyz, bundle report |
bc8cd00 to
8cabe0c
Compare
|
|
427ee9e to
b170531
Compare
davidyuk
reviewed
Apr 1, 2021
There was a problem hiding this comment.
- is landing/favicon.png used?
- landing/github copy.png looks the same as landing/github.png
- src/assets/landing/github.png seems to be not used
- src/assets/landing/section6-background.png seems to be not used
- src/assets/landing/slide1.png seems to be not used
- src/assets/landing/social-card.png seems to be not used
- icon-share.svg and voting-icon.svg looks the same
- src/assets/landing/join_superhero_looper.png seems to be not used
Comment on lines
+375
to
+463
| .landing-page { | ||
| background: #f2f2f2; | ||
| color: #212529; | ||
| font-family: Oxygen, sans-serif; | ||
| font-weight: 400; | ||
| line-height: 1.5; | ||
| margin: 0 auto; | ||
| max-width: 100vw !important; |
There was a problem hiding this comment.
Suggested change
| .landing-page { | |
| background: #f2f2f2; | |
| color: #212529; | |
| font-family: Oxygen, sans-serif; | |
| font-weight: 400; | |
| line-height: 1.5; | |
| margin: 0 auto; | |
| max-width: 100vw !important; | |
| #app.landing-page { | |
| background: #f2f2f2; | |
| color: #212529; | |
| font-family: Oxygen, sans-serif; | |
| font-weight: 400; | |
| line-height: 1.5; | |
| margin: 0 auto; | |
| max-width: none; |
(none is a default value)
There was a problem hiding this comment.
That is to avoid calculating the scrollbar width
There was a problem hiding this comment.
I think you need just to stretch the layout to the whole screen (in other screens max-width is limited by container-with variable)
davidyuk
reviewed
Apr 8, 2021
davidyuk
requested changes
Apr 8, 2021
ffd5cbd to
5c5634b
Compare
venimus
commented
Apr 12, 2021
|
Some padding is missing on mobile and the last buttons are misaligned. Screen.Recording.2021-04-12.at.13.26.56.mov |
davidyuk
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.