channels: typo and language styling updates #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any hope to have this merged? It's a cosmetic change. |
|
Ping |
velzevur
reviewed
Aug 4, 2021
| @@ -96,8 +96,8 @@ improvements are as follows: | |||
| On-chain interactions offer little to no privacy, since we currently make no | |||
| efforts to hide interacting parties or the nature of their interactions. | |||
|
|
|||
| State channels, at the least, reveal that two parties establish a channel and | |||
| the amount of coins they commit to the channel, which is no improvement. | |||
| Basic State channels reveal that two parties establish a channel and | |||
There was a problem hiding this comment.
Suggested change
| Basic State channels reveal that two parties establish a channel and | |
| Establishing a State channel reveals that two parties open a channel and |
Basic reads as a new term, one we have not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the channels documentation I fixed few language issues.