Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AE coin markets #835

Merged
merged 41 commits into from
Jul 15, 2024
Merged

feat: AE coin markets #835

merged 41 commits into from
Jul 15, 2024

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Jun 6, 2024

Description

resolves #822

Demo

firefox_7zfKte4BJf.mp4

Checklist:

Copy link

github-actions bot commented Jun 6, 2024

@janmichek janmichek force-pushed the ae-coin-markets branch 2 times, most recently from 4c3a4c1 to 70b3593 Compare June 12, 2024 09:05
@@ -9,6 +9,13 @@ export default defineNuxtConfig({
devServer: {
port: 8080,
},
nitro: {
routeRules: {
'/proxy/gate': { proxy: 'https://api.gateio.ws/api/v4/spot/tickers?currency_pair=AE_USDT', cors: true },
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the request needed to be passed through proxy to get over CORS. Some links didn't need this approach

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janmichek please check the description for 3 first column:

2024-06-13.1.33.59.mov

@janmichek
Copy link
Collaborator Author

@janmichek please check the description for 3 first column:
2024-06-13.1.33.59.mov

Thanks, fixed

@janmichek janmichek requested a review from Liubov-crypto June 13, 2024 11:03
@Liubov-crypto
Copy link
Collaborator

LGTM

@janmichek janmichek merged commit 31da7e4 into develop Jul 15, 2024
3 checks passed
@janmichek janmichek deleted the ae-coin-markets branch July 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AE coin markets
3 participants