-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unused attempt for account names counter #600
fix: remove unused attempt for account names counter #600
Conversation
Deployed to https://pr-600-aescan.stg.service.aepps.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understood the name counter isn't implemented yet on middleware's side. Besides that LGTM.
But I have a question: I noticed that on other pr name counter is working correctly and showing number of names. @janmichek Correct me if I'm wrong:
2023-11-22.6.48.42.mov
@Liubov-crypto firefox_qmAx5nx3Bq.mp4I removed that field for now, until we resolve it and will be able to show correct number. |
LGTM. AENS Names counter has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, it was counting first page only.
Description
Initially I grabbed the issue #553
Found out that
Demo
Without any visual change. Should work the same
Checklist: