feat: Consider using feat view related utility classnames #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-519-aescan.stg.aepps.com |
lukeromanowicz
approved these changes
Oct 6, 2023
michele-franchi
approved these changes
Oct 19, 2023
| .token-holders-panel { | ||
| &__table { | ||
| display: none; | ||
| margin-bottom: var(--space-4); |
There was a problem hiding this comment.
margin-bottom: var(--space-4); got removed. Can you check it?
There was a problem hiding this comment.
Nope, for this case was not needed. Forgot to comment this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #93
I think it was a good time to use utility classes. I am not against utility classes, but should be used as a syntactic sugar, when in benefits from huge code elimination like in this example. Just wanted to avoid premature usage before.
Demo
Visually without a change
Checklist: