Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Loading indicator for panels 2 #441

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Aug 9, 2023

Description

fixes #391

Demo

firefox_8Fz0RHlF1N.mp4

Checklist:

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Deployed to https://pr-441-aescan.stg.aepps.com

Copy link
Contributor

@lukeromanowicz lukeromanowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, it works pretty decently but it involves slight code duplication that we can easily reduce by creating a composable. In the future we could probably add some animation to make it even nicer but I don't think we should focus on that right now

src/pages/state-channels/index.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good to me. The only thing I noticed is that the vertical padding in the panel looks less then the one applied with tables so I would keep the same one but I approve in advance.

@janmichek
Copy link
Collaborator Author

It looks really good to me. The only thing I noticed is that the vertical padding in the panel looks less then the one applied with tables so I would keep the same one but I approve in advance.

Good catch, adjusted

Copy link
Contributor

@lukeromanowicz lukeromanowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested one minor improvement for the sake of consistency and I think it would be also nice to somehow preload or at least cache the loading indicator svg so it's visible in the very beginning just like the loading text.

That being said these are minor stuff that we can also fix with a follow-up task if you want.

image

2023-08-10.08-43-06.mp4

src/composables/useLoading.js Outdated Show resolved Hide resolved
@lukeromanowicz
Copy link
Contributor

@janmichek please ignore the part about caching... I had "disable caching" enabled 🤦‍♂️

@Liubov-crypto
Copy link
Collaborator

LGTM

@janmichek janmichek merged commit 7b883f8 into develop Aug 10, 2023
@janmichek janmichek deleted the Loading-indicator-for-panels-2 branch August 10, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading indicator for panels
4 participants