feat: Keyblock microblocks table #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-382-aescan.stg.aepps.com |
michele-franchi
requested changes
Jul 20, 2023
| v-for="microblock in microblocks.data" | ||
| :key="microblock.hash"> | ||
| <td> | ||
| <app-link :to="`/micro-blocks/${microblock.hash}`"> |
There was a problem hiding this comment.
Suggested change
| <app-link :to="`/micro-blocks/${microblock.hash}`"> | |
| <app-link :to="`/microblocks/${microblock.hash}`"> |
The link is incorrect
I was following the visual material. No strong preference here
I was also following the visual material. Here I would prefer label as well. What do you think about those changes @danilosierrac ? |
lukeromanowicz
approved these changes
Jul 21, 2023
| const { fetchKeyblockMicroblocks } = useKeyblockDetailsStore() | ||
| const route = useRoute() | ||
| const limit = computed(() => process.client && isDesktop() ? 10 : 3) | ||
| fetchKeyblockMicroblocks({ |
There was a problem hiding this comment.
I think this should be fetched on the client side only. Right now it's fetched also on server-side but the SSR doesn't wait for the response so you don't see any warnings
michele-franchi
requested changes
Jul 24, 2023
Ok, both adjusted |
michele-franchi
approved these changes
Jul 24, 2023
CharisSiarampalis
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #369
Demo
firefox_ViAWRf1ZeL.mp4
Checklist: