-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: seo keywords and robots.txt #352
Conversation
Deployed to https://pr-352-aescan.stg.aepps.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, it seems to be a promising solution. 👏 I guess the only way to find out is to deploy it on main domain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukeromanowicz Did you also have a look at this comment about page titles consistency?
#44 (comment)
Not sure if it's fixed.
@michele-franchi Yes, it has been already fixed 2 months ago but released very recently in 0.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a personal opinion but other than that it looks good!
@@ -45,7 +45,8 @@ export const NUMBER_FRACTION_THRESHOLD = 100000 | |||
export const MAXIMUM_FRACTION_DIGITS = 20 | |||
export const APP_TITLE_SHORT = 'æScan' | |||
export const APP_TITLE = 'æScan - æternity Blockchain Explorer' | |||
export const APP_DESCRIPTION = 'æScan is a blockchain explorer, analytics platform, and decentralized Smart Contract navigation platform based on æternity' | |||
export const APP_DESCRIPTION = 'æScan is a blockchain explorer, analytics platform, and decentralized Smart Contract navigation platform based on æternity.' | |||
export const APP_KEYWORDS = 'aescan, aeternity, blockchain, explorer, search, crypto, currency' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion I would remove "search, crypto, currency".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took that inspiration from etherscan and it seems to be working pretty well for them. @janmichek WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding of this topic is low, but the motivation behind choosing such keywords make complete sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we would be left with only 4 keywords which are well within the usual number of keywords, I'll keep them then.
Description
I hope it resolves #44 but we will be able to find out once it's shipped to production.
Demo
Checklist: