Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seo keywords and robots.txt #352

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

lukeromanowicz
Copy link
Contributor

@lukeromanowicz lukeromanowicz commented Jun 27, 2023

Description

I hope it resolves #44 but we will be able to find out once it's shipped to production.

Demo

image
image

Checklist:

  • I have read and followed the Contributing Guide
  • My change does not require a change to the documentation.

@github-actions
Copy link

Deployed to https://pr-352-aescan.stg.aepps.com

Copy link
Collaborator

@janmichek janmichek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, it seems to be a promising solution. 👏 I guess the only way to find out is to deploy it on main domain

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukeromanowicz Did you also have a look at this comment about page titles consistency?
#44 (comment)

Not sure if it's fixed.

@lukeromanowicz
Copy link
Contributor Author

@michele-franchi Yes, it has been already fixed 2 months ago but released very recently in 0.3.0

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a personal opinion but other than that it looks good!

@@ -45,7 +45,8 @@ export const NUMBER_FRACTION_THRESHOLD = 100000
export const MAXIMUM_FRACTION_DIGITS = 20
export const APP_TITLE_SHORT = 'æScan'
export const APP_TITLE = 'æScan - æternity Blockchain Explorer'
export const APP_DESCRIPTION = 'æScan is a blockchain explorer, analytics platform, and decentralized Smart Contract navigation platform based on æternity'
export const APP_DESCRIPTION = 'æScan is a blockchain explorer, analytics platform, and decentralized Smart Contract navigation platform based on æternity.'
export const APP_KEYWORDS = 'aescan, aeternity, blockchain, explorer, search, crypto, currency'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion I would remove "search, crypto, currency".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took that inspiration from etherscan and it seems to be working pretty well for them. @janmichek WDYT?
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding of this topic is low, but the motivation behind choosing such keywords make complete sense to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we would be left with only 4 keywords which are well within the usual number of keywords, I'll keep them then.

@lukeromanowicz lukeromanowicz merged commit 40099d8 into develop Jun 28, 2023
@lukeromanowicz lukeromanowicz deleted the feat/seo-improvements branch June 28, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SEO to score top search results
3 participants