fix: expose port 8080 in Docker #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪️ Preview Links 🔎️Mainnet: https://pr-1060-aescan.stg.service.aepps.com |
janmichek
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Most tests are passing, but those affected by MDW issue does not. Thats acceptable for now, nothing we can do to fix it fast. Hopefully, I didn't overlook anything; it's sketchy currently.
I think the issue is solved. I tried new PR, based on this branch and was built successfully #1062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port 8080 has to be exposed, instead of 80, because the process is started by a non-root user which can't expose ports like 80.
Demo
Checklist: