Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make aeraki address configurable #327

Merged
merged 1 commit into from
Apr 5, 2023
Merged

make aeraki address configurable #327

merged 1 commit into from
Apr 5, 2023

Conversation

tanjunchen
Copy link
Member

@tanjunchen tanjunchen commented Apr 4, 2023 •
edited
Loading

What this PR does / Why we need it:

Pre-Submission Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
    Support for aeraki to be installed in other namespaces

image

  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

@mergify mergify bot requested a review from zhaohuabing April 4, 2023 06:42
@tanjunchen tanjunchen force-pushed the optimize-code branch 4 times, most recently from 4974532 to 1c36cf6 Compare April 4, 2023 07:15
zhaohuabing
zhaohuabing reviewed Apr 4, 2023
View reviewed changes
pkg/config/constants/constants.go Outdated
@@ -18,3 +18,11 @@ const (
// AerakiFieldManager is the FileldManager for Aeraki CRDs
AerakiFieldManager = "Aeraki"
)

const (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: merge two const blocks into one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.I will update it.

@zhaohuabing zhaohuabing changed the title aeraki support other namespace install option make aeraki address configurable Apr 4, 2023
@tanjunchen tanjunchen force-pushed the optimize-code branch 4 times, most recently from db08a2f to fd2f7b2 Compare April 4, 2023 13:39
@tanjunchen
aeraki support other namespace install option
ffed8c6 
Signed-off-by: chentanjun <tanjunchen20@gmail.com>
@zhaohuabing zhaohuabing merged commit 34e75f5 into aeraki-mesh:master Apr 5, 2023
@tanjunchen tanjunchen deleted the optimize-code branch April 5, 2023 04:16
@tanjunchen tanjunchen mentioned this pull request Apr 23, 2023
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanjunchen @zhaohuabing