Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon #519

Merged
merged 8 commits into from
Jul 24, 2023
Merged

New icon #519

merged 8 commits into from
Jul 24, 2023

Conversation

fer0n
Copy link
Contributor

@fer0n fer0n commented Jul 24, 2023

No description provided.

@fer0n
Copy link
Contributor Author

fer0n commented Jul 24, 2023

@aeharding

  • I checked with L1C4U5E@lemmy.world and they're fine with the fediverse-star-sign being in here
  • If you want to credit me somewhere, my Github profile probably makes the most sense (I'd prefer my GitHub username)
  • Regarding the licence, do you need me to put something somewhere in a file or is it enough to tell you that it's all my stuff that I'm uploading here?
  • Would you like the source file for all the variations etc in case something needs to be adjusted in the future (affinity designer)? If so, where would you like me to upload it?
  • I think it'd make sense to let people know how they can customise the icon on iOS/Android. As mentioned before, on iOS there's this shortcut that can be used (alongside other options) and I'm guessing there's a way to do that on Android as well. It would probably be best to do that alongside the URLs of the other contenders (maybe some more of the original submitted ones, I'm sure there are some in there that other people would prefer). There could also be a settings option that explains how and provides some alternative icons to choose from, although I'm not sure if the better way would be to wait for the potential native wrapper and do it there properly.

Let me know if something isn't quite right or you have any questions :)

@aeharding
Copy link
Owner

  • Just added credits and license to the readme! Let me know if that's fine with you.
  • For source files, can you attach them to this issue and/or a discussion? Then I can add them to a wiki page.
  • I'll definitely mention that workaround for custom icon :)
  • Lastly, I plan on working on an "about" page in the app which will be a good place for logo credit in-app! Does that sound good?

@fer0n
Copy link
Contributor Author

fer0n commented Jul 24, 2023

All of that is perfect, thanks :)

@fer0n
Copy link
Contributor Author

fer0n commented Jul 24, 2023

Here's the source file (Affinity Designer)
Voyager icon.zip

@aeharding aeharding merged commit 918ce90 into aeharding:main Jul 24, 2023
@fer0n fer0n deleted the new-icon branch July 25, 2023 15:10
@fer0n
Copy link
Contributor Author

fer0n commented Jul 25, 2023

@aeharding I noticed that the icon looks a bit blurry, for one a 1024x1024 version isn't linked and for another no matter what I do safari is always picking a lower res version (I think 180x180) even if a better one is available. The only thing that seems to help is remove all except 1024x1024. I don't think that would have any side effects and as I understand it it could still fall back to the "shortcut icon" (logo.png). Changing it in the manifest also doesn't affect anything.

Do you think it's worth removing everything except for a 1024x1024 (420kb) version (App Store app icon size)?. 512x512 (135kb) is also a lot better. I attached an image, from left to right it's: current icon (prob. 128), 512, 1024
image

@aeharding
Copy link
Owner

@fer0n please do!

@fer0n
Copy link
Contributor Author

fer0n commented Jul 25, 2023

#526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants