Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default comment sort option. #210

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

Faalangst26
Copy link
Contributor

@Faalangst26 Faalangst26 commented Jul 3, 2023

Added the ability to set a default sort type for comments in the appearance menu, as it was a personal pet peeve of mine to have comments sorted to hot by default.

resolves #43

@Faalangst26
Copy link
Contributor Author

resolved merge conflicts

Copy link
Contributor

@rsammelson rsammelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great feature! I looked over the code and noticed a couple things.

src/features/settings/appearance/CollapsedByDefault.tsx Outdated Show resolved Hide resolved
src/features/settings/appearance/appearanceSlice.tsx Outdated Show resolved Hide resolved
src/features/settings/appearance/PostView.tsx Outdated Show resolved Hide resolved
@Faalangst26 Faalangst26 requested a review from rsammelson July 4, 2023 13:21
@rsammelson
Copy link
Contributor

This fixes #43, right?

@Faalangst26
Copy link
Contributor Author

resolved merge conflicts

@jmaruiz
Copy link
Contributor

jmaruiz commented Jul 6, 2023

Nice work! Been wanting this feature and learned something reading through the PR!

@aeharding
Copy link
Owner

Thanks @Faalangst26 for keeping this up to date with main.

We will hopefully get the storage stuff in tomorrow (🤞) and then unblock this

@aeharding
Copy link
Owner

@Faalangst26 The DB work is done, so this should be ready to merge once conflicts resolved and updated to use the new db service! :)

Let me know if you have time in the next few days! Thank you!

@Faalangst26
Copy link
Contributor Author

I'm on holiday at the moment, so I won't be able to resolve until I get back. You can close it if you want someone else to implement it in the meantime.

@rsammelson
Copy link
Contributor

I can take over resolving the conflicts.

@rsammelson
Copy link
Contributor

@Faalangst26 I resolved the conflicts but I can't push them here, should I open a PR onto your branch, open a new PR replacing this one, or I could let @aeharding push the changes to your branch if he would like to. I pushed it to https://github.com/rsammelson/wefwef/tree/default-comment-sort.

@Faalangst26
Copy link
Contributor Author

@rsammelson I could merge it with this one if you open a PR with my branch. Alternatively you could just open a new PR on this repo and mention this one so it can get merged with main.

@rsammelson
Copy link
Contributor

@Faalangst26, done

@aeharding
Copy link
Owner

Thanks for the pr. I'd like to get this in tomorrow if you have time.

Just checked - The appearance settings page needs some work. Tapping one of the options blanks out the page and the options are grouped strangely.

Also, sort isn't really an appearance setting. We should really make a general settings page. However, I'm fine merging this once the above gets resolved and we can fix this as part of a larger settings page refactor :)

@aeharding aeharding force-pushed the DefaultCommentSort branch from 5d9af1d to b68b858 Compare July 15, 2023 23:18
@aeharding
Copy link
Owner

I've resolved conflicts, moved the setting to a new general page, and refactored a few things.

This should now be pretty much ready. If anyone want to test that would be appreciated.

Co-authored-by: Berne Gerrits <31410921+Faalangst26@users.noreply.github.com>
@aeharding aeharding force-pushed the DefaultCommentSort branch from b68b858 to e0ea81f Compare July 15, 2023 23:20
@aeharding aeharding merged commit 89ad285 into aeharding:main Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default comment sort
4 participants