-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow showing downvotes separately or hiding scores #185
Conversation
68979b1
to
602320a
Compare
602320a
to
678d378
Compare
678d378
to
8325b0f
Compare
850f73c
to
3c9f3ab
Compare
3c9f3ab
to
13c1221
Compare
I accidentally ended up with this branched off of my changes from #209, so I'm going to wait until that is merged to get this one ready to merge. |
50aaf17
to
a9927c2
Compare
This is now waiting on #470 instead. |
a9927c2
to
1a100e5
Compare
@aeharding can you take a look at this? |
@rsammelson I made some adjustment here, if you want to cherrypick or I can PR to yours. |
e26f230
to
96d83b6
Compare
I just saw your comment, I must have started working on it at the same time as you. I brought over some more changes from your commit in the most recent push. |
96d83b6
to
75907d7
Compare
Oh oops! Can we keep "cumulative"? I have that in e8861fb and I would add it but it looks like I don't have permission to push to your branch. |
Yeah I can change it, I called it "net score" though which seems more precise |
"Total" would also work. I want to leave off "Score" though because it's not consistent with the other options to add for that one only Do you know if there's some config you can adjust so I may push to this branch? |
75907d7
to
4cd61ec
Compare
I adjusted it now |
Please check that option. I don't know why github words it that way. |
Yeah on reading the help page the secrets can only possibly give modify access to other branches of the same repo, so it's not actually a security issue in this case |
79726b2
to
b197dd4
Compare
b197dd4
to
fd849ef
Compare
When I rebased on to main a while ago I forgot to apply the cleanup I did to the new settings. |
Thanks. This looks good. I wonder if the downvotes should be hidden if none in separate mode. In the comments it gets a little busy with a bunch of zeroes that are not necessary. that's something for another pr though |
Fixes #170 and fixes #135. When the setting is in the default mode, it should work the same as before.