Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark & tinted icon variants for default app icon #1607

Merged
merged 10 commits into from
Oct 2, 2024

Conversation

fer0n
Copy link
Contributor

@fer0n fer0n commented Sep 27, 2024

Most dark versions aren't really all that dark, but I couldn't come up with anything non-white that I found still looked acceptable, but perhaps someone else has success there.

Also, here's the updated source file:
Voyager icon.zip

What do you think? (tined left, dark mid & right variants)
I sometimes went with the opaque and sometimes the transparent background, for some I think that makes more sense than for others. Do you have any preference there?
Picsew_20240928195257

@fer0n fer0n requested a review from aeharding as a code owner September 27, 2024 06:22
@aeharding
Copy link
Owner

Looks great 😍 I think I like the dark mode grey BG better, it seems to match better with other iOS icons.

I'll leave it to your discretion, though. We can also tweak in the future. So let me know when you're happy and I'll get this in.

@fer0n
Copy link
Contributor Author

fer0n commented Sep 29, 2024

I've been staring at them way too long. I think isolated the ones with a colorful background look nicer, but the gray ones fit in better. Psych fits in best, holidays is also not too bad.

For the other ones I'm still struggling, but it's probably best to make them fit in more. For planetary I'll stick with the custom background, it has too much color everywhere and I don't think it matches the gray very well.

As you said, we can always tweak it later. As far as I'm concerned you can merge it, but if you want any changes I'm fine with that as well.

@aeharding aeharding merged commit e6fad9b into aeharding:main Oct 2, 2024
2 checks passed
@mrtzlbm
Copy link

mrtzlbm commented Oct 15, 2024

Love these! Are they supposed to work already with version >2.18? I tried both the app store as well as the testflight version and in neither did the dark or tinted icons get applied (on iOS 18.0.1).

@fer0n
Copy link
Contributor Author

fer0n commented Oct 16, 2024

@mrtzlbm I don't think they're in any release yet

@mrtzlbm
Copy link

mrtzlbm commented Oct 20, 2024

Hi @aeharding, are these new app icon styles supposed to work already with Voyager version >2.18 since this has been merged and mentioned in the release notes? I tried both the App Store as well as the TestFlight version and in neither did the dark or tinted icons get applied (iOS 18.0.1). Thanks!

@aeharding
Copy link
Owner

Yes, they are. Can you send a screenshot of what you're seeing? Also, try restarting your device, sometimes iOS caches icons strangely

@fer0n
Copy link
Contributor Author

fer0n commented Oct 20, 2024

Restart definitely doesn't hurt, but iOS 18 seems to have fixed that issue, before it never changed without it.

The icon itself changes for me, but the dark version doesn't show up. Does it work for you @aeharding?

@aeharding
Copy link
Owner

Works fine.
IMG_D719A3D2F4D9-1

@fer0n
Copy link
Contributor Author

fer0n commented Oct 20, 2024

Is that the App Store Version? I tried both TestFlight and App Store, restarted and changed icons, but the dark version never shows up.

@aeharding
Copy link
Owner

Works in dev, not in store/testflight. 🤦‍♂️ I'm not sure what the issue is.

@aeharding
Copy link
Owner

I figured it out, the build agent was using an old version of Xcode!

@mrtzlbm
Copy link

mrtzlbm commented Oct 21, 2024

@aeharding Awesome you found the bug already! Here is my screen recording anyway: https://imgur.com/a/gezNXHY 😅

@fer0n
Copy link
Contributor Author

fer0n commented Oct 21, 2024

It works now, thanks :)

@aeharding
Copy link
Owner

Really love these. Especially the Pride flag, it has a nice pop. Thanks again @fer0n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants